Skip to content

Add RSA PKCS#1 pubkey loader - #167

Merged
randombit merged 3 commits into
randombit:masterfrom
arckoor:rsa-pkcs1-pubkey
Mar 3, 2026
Merged

Add RSA PKCS#1 pubkey loader#167
randombit merged 3 commits into
randombit:masterfrom
arckoor:rsa-pkcs1-pubkey

Conversation

@arckoor

@arckoor arckoor commented Jan 10, 2026

Copy link
Copy Markdown
Contributor

Also bumps the FFI version. Needs botan 3.11

@arckoor

arckoor commented Jan 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Ooft, for the ci (stable, git) failure I am once again clueless, iirc it's the same as in #166. For the ci (1.64.0, ...) failure, it seems to mainly be a symptom of not committing the Cargo.lock. My local one was generated a while ago, so there all is green (I'm pulling in quote v1.0.40), while the CI runner is generating it on the fly, and as such pulls in quote v1.0.43, which has an MSRV of 1.68.

So the solution would probably be to either commit the lockfile, or bump MSRV, I'd be for committing the lockfile, especially since quote is only a transitive dev dependency via wycheproof for the tests.

arckoor
arckoor commented Jan 15, 2026
View reviewed changes
Comment thread .ci/build.py
Comment on lines +121 to +122
os.environ["RUSTFLAGS"] = "-D warnings -L/usr/local/lib"
os.environ["RUSTDOCFLAGS"] = "-D warnings -L/usr/local/lib"

@arckoor arckoor Jan 15, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why it worked so far, I don't know why it doesn't work anymore, but this fixes the CI git failure

@arckoor
arckoor force-pushed the rsa-pkcs1-pubkey branch from 7256b51 to 7aceeca Compare March 3, 2026 12:49
@arckoor
arckoor force-pushed the rsa-pkcs1-pubkey branch from 7aceeca to 56a032f Compare March 3, 2026 14:10
randombit
randombit approved these changes Mar 3, 2026
View reviewed changes

@randombit randombit left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the long wait here

@randombit

randombit commented Mar 3, 2026

Copy link
Copy Markdown
Owner

CI failure is unrelated, I'll merge then address

@randombit
randombit merged commit f372640 into randombit:master Mar 3, 2026
15 of 17 checks passed
@arckoor
arckoor deleted the rsa-pkcs1-pubkey branch March 3, 2026 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@randombit randombit randombit approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arckoor @randombit