Skip to content

fix: treat bare bool flags as true#13

Merged
ChenJesse merged 1 commit into
mainfrom
jesse/fix-bare-bool-flags
May 27, 2026
Merged

fix: treat bare bool flags as true#13
ChenJesse merged 1 commit into
mainfrom
jesse/fix-bare-bool-flags

Conversation

@ChenJesse
Copy link
Copy Markdown
Contributor

@ChenJesse ChenJesse commented May 27, 2026

Summary

  • Bare boolean flags like --dry-run (without =true) are now treated as true
  • Previously, --dry-run was silently ignored because the flag parser only populated the FlagArg when a value was provided via = (e.g. --dry-run=true)
  • This matches standard CLI conventions where passing a boolean flag without a value means "enable it"

Test plan

  • Updated existing test case for bare bool flags
  • All TestParseTaskOptionsListToMap subtests pass

🤖 Generated with Claude Code


View with Codesmith Autofix with Codesmith
Need help on this PR? Tag @codesmith with what you need. Autofix is disabled.

`--dry-run` (without `=true`) was silently ignored because the flag
parser only populated the FlagArg when a value was provided via `=`.
Now bare boolean flags are implicitly treated as `true`, matching
standard CLI conventions.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@ChenJesse ChenJesse force-pushed the jesse/fix-bare-bool-flags branch from 27b8d1b to 0211944 Compare May 27, 2026 22:03
@ChenJesse ChenJesse merged commit a4f995b into main May 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant