fix: distinguish bare bool flags from explicit empty value#14
Merged
Conversation
--flag (bare, no =) → true --flag= (explicit empty) → falls through to default Prevents --flag=$UNSET_VAR from silently being treated as true. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #13. The previous fix treated both
--flag(bare) and--flag=(explicit empty) astrue. This is wrong —--flag=$UNSET_VARexpanding to--flag=should not silently activate the flag.Now only truly bare flags (
len(splitFlag) == 1, no=present) default totrue.Test plan
--flag=does not default to true--flagstill treated as trueTestParseTaskOptionsListToMapsubtests pass🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.