Night owl support#11
Open
sfider wants to merge 9 commits into
Open
Conversation
…erly report late night work
…ay_start_hour" This reverts commit 3214d4ca12cdd20e8f72546e682cc9bf715b6a05.
Member
|
Hey @sfider, thanks so much! I've ran tests on your branch and it seems to fail: Also @teutat3s I thought we enabled checks for this repo, maybe it's not running for PRs with external branches yet? I'll check if I can find out why |
Member
|
If you rebase this on latest |
Contributor
Author
|
All failing tests assume the config won't be read on Watson object initialization. I broke that assumption by reading 'day_start_hour' from config in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Went through the trouble of switching my fork to your repo just to PR this hacky thing. Hope you'll enjoy it :)