Support for night owls: starting a day at later hour, e.g. 6, to properly report late night work#4
Closed
b12f wants to merge 3 commits into
Closed
Support for night owls: starting a day at later hour, e.g. 6, to properly report late night work#4b12f wants to merge 3 commits into
b12f wants to merge 3 commits into
Conversation
teutat3s
force-pushed
the
night-owl-support
branch
from
eb1b017 to
f0f4328
Compare
…erly report late night work
…ay_start_hour" This reverts commit 3214d4ca12cdd20e8f72546e682cc9bf715b6a05.
teutat3s
force-pushed
the
night-owl-support
branch
from
f0f4328 to
e0ff01e
Compare
teutat3s
approved these changes
Aug 19, 2024
Contributor
|
Hi, I did some fixes to the original pull request, it's kind of hacky, but I think it finally works as intended ^^ BTW. what's up with this repo, and the original for that matter? I assume the original changed ownership, but is rather stale. And this one's not a fork connected to the original? |
Member
Author
|
Hey @sfider and thanks for the heads-up. If you like, you can create a PR against this repo, or we'll import your commits here. The reason our fork is not forked the "github way" is explained in these two comments: |
Member
Author
|
Clsoing in favour of #11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I like to work late at night, even after midnight. Using Watson in such a setting means reports will count part of my work as being done on the next day, while it was done on the same day from my perspective. I've added 'day_start_hour' option to shift time spans used for reports/aggregates to account for me working late.
Original PR: jazzband/Watson#457