Conversation
Post-promotion minor bump after the develop->main two-phase release, so develop's prereleases (3.18.x-g{sha}) sort above the shipped 3.17.x.
Bumps csharpier from 1.2.6 to 1.3.0 Bumps InsaneGenius.Utilities from 3.4.3 to 3.4.18 Bumps ptr727.LanguageTags from 1.2.51 to 1.2.54 --- updated-dependencies: - dependency-name: csharpier dependency-version: 1.3.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps - dependency-name: InsaneGenius.Utilities dependency-version: 3.4.18 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps - dependency-name: ptr727.LanguageTags dependency-version: 1.2.54 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Carry the template's .markdownlint-cli2.jsonc verbatim so the davidanson IDE extension and CLI markdownlint-cli2 apply the same rules, and add jsonc to the .editorconfig JSON glob so the config file is CRLF-governed. Existing docs already pass cleanly (0 errors). Realigns with ptr727/ProjectTemplate. Part of #731.
There was a problem hiding this comment.
Pull request overview
This PR promotes develop to main while realigning repo linting/editor settings with the shared ProjectTemplate conventions, and rolls in the next prerelease-cycle version bump plus dependency/tool updates.
Changes:
- Add a shared
.markdownlint-cli2.jsoncconfiguration intended to align IDE and CLI markdown linting behavior. - Update
.editorconfigto apply JSON CRLF rules to both*.jsonand*.jsonc. - Bump the NBGV base version and update selected NuGet and dotnet-tool versions.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
version.json |
Updates the base Nerdbank.GitVersioning version. |
Directory.Packages.props |
Bumps centralized NuGet package versions for Utilities/LanguageTags. |
.markdownlint-cli2.jsonc |
Introduces the shared markdownlint-cli2 JSONC config. |
.editorconfig |
Expands JSON EOL rules to cover JSONC. |
.config/dotnet-tools.json |
Updates the pinned csharpier dotnet-tool version. |
| { | ||
| "$schema": "https://raw.githubusercontent.com/dotnet/Nerdbank.GitVersioning/master/src/NerdBank.GitVersioning/version.schema.json", | ||
| "version": "3.17", | ||
| "version": "3.18", |
There was a problem hiding this comment.
Flagging this for the maintainer rather than resolving it myself: the version.json base bump to 3.18 came from an existing maintainer commit (#726) already on develop, and this PR is a straight develop -> main promotion that carries it. Whether 3.18 should land on main now is a release-cadence decision for the maintainer - holding this PR's merge pending that call.
|
Closing in favor of a maintenance promotion that holds the version. This was a develop -> main promotion of catch-up work (template markdownlint realignment), but it also carried the version.json bump to 3.18. Per the versioning rules (maintenance/catch-up promotions must not bump main's version, and develop stays a minor ahead), replaced by #NEW which keeps main at 3.17. |
Promotes
developtomain. Realignment with ProjectTemplate (#732): shared markdownlint config + jsonc editorconfig glob. Also rolls up the next prerelease version bump (#726) and a dependency bump (#730).