Adopt shared markdownlint config (maintenance promotion, no version bump)#734
Merged
Conversation
Post-promotion minor bump after the develop->main two-phase release, so develop's prereleases (3.18.x-g{sha}) sort above the shipped 3.17.x.
Bumps csharpier from 1.2.6 to 1.3.0 Bumps InsaneGenius.Utilities from 3.4.3 to 3.4.18 Bumps ptr727.LanguageTags from 1.2.51 to 1.2.54 --- updated-dependencies: - dependency-name: csharpier dependency-version: 1.3.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps - dependency-name: InsaneGenius.Utilities dependency-version: 3.4.18 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps - dependency-name: ptr727.LanguageTags dependency-version: 1.2.54 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Carry the template's .markdownlint-cli2.jsonc verbatim so the davidanson IDE extension and CLI markdownlint-cli2 apply the same rules, and add jsonc to the .editorconfig JSON glob so the config file is CRLF-governed. Existing docs already pass cleanly (0 errors). Realigns with ptr727/ProjectTemplate. Part of #731.
This develop -> main promotion carries catch-up/maintenance work (template markdownlint realignment + dependency bumps), not a release. Per the versioning rules, maintenance promotions must not bump main's version: reset version.json to main's current value (3.17) so develop stays a minor ahead (3.18) and main does not advance.
There was a problem hiding this comment.
Pull request overview
This PR intends to promote the shared markdownlint alignment from develop to main by adding a repository-wide markdownlint-cli2 configuration and updating .editorconfig to treat jsonc like json for line ending rules.
Changes:
- Add
.markdownlint-cli2.jsoncshared markdownlint configuration. - Update
.editorconfigJSON section glob to includejsonc. - (Scope discrepancy) Also bumps NuGet package versions and the pinned
csharpierdotnet tool version, which is not described as part of this maintenance promotion.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Directory.Packages.props | Updates package versions (not mentioned in PR description). |
| .markdownlint-cli2.jsonc | Adds shared markdownlint-cli2 config at repo root. |
| .editorconfig | Expands JSON glob to include jsonc for CRLF governance. |
| .config/dotnet-tools.json | Bumps csharpier tool version (not mentioned in PR description). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintenance/catch-up promotion of accumulated
developwork fromdeveloptomain, without a version bump. Replaces #733.Changes promoted (all maintenance/catch-up):
.markdownlint-cli2.jsonc+.editorconfig- template markdownlint realignment (Adopt shared markdownlint config #732)Directory.Packages.props+.config/dotnet-tools.json- dependency / dotnet-tool bumps (Bump the nuget-deps group with 3 updates #730)Version held:
version.jsonis kept at main's current value (3.17) rather than promoting develop's3.18. This is catch-up, not a release, somaindoes not advance anddevelopstays a minor ahead.