Skip to content

fix(cli): unify PF diagnostics without sudo - #318

Draft
munezaclovis wants to merge 3 commits into
agent/fix-pf-gateway-readinessfrom
agent/unify-pf-diagnostics
Draft

fix(cli): unify PF diagnostics without sudo#318
munezaclovis wants to merge 3 commits into
agent/fix-pf-gateway-readinessfrom
agent/unify-pf-diagnostics

Conversation

@munezaclovis

Copy link
Copy Markdown
Contributor

Depends on #317.

Closes #306.

Summary

  • bind the Gateway health identity to its assigned backend ports
  • classify low-port routing once as active, inactive, drifted, or unknown
  • use direct unprivileged pfctl evidence with bounded HTTP and HTTPS identity-probe fallback
  • expose matching plain and JSON diagnostics from status, doctor, and ports:status
  • make ports:status exit successfully only for verified active routing

Tests

  • cargo test -p daemon --test gateway_config
  • cargo test -p daemon --test supervisor_foundation gateway_identity_readiness
  • cargo test -p cli --test doctor
  • cargo test -p cli --test status
  • cargo test -p cli --test ports
  • cargo clippy -p cli --all-targets -- -D warnings
  • cargo clippy -p daemon --all-targets -- -D warnings

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d033f427-e782-4da4-a843-4f3f991dae1b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codspeed-hq

codspeed-hq Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 7 untouched benchmarks


Comparing agent/unify-pf-diagnostics (898e44c) with agent/fix-pf-gateway-readiness (7ece4ca)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant