Skip to content

fix(diagnostics): resolve superseded job failures - #319

Draft
munezaclovis wants to merge 4 commits into
agent/unify-pf-diagnosticsfrom
agent/resolve-current-job-failures
Draft

fix(diagnostics): resolve superseded job failures#319
munezaclovis wants to merge 4 commits into
agent/unify-pf-diagnosticsfrom
agent/resolve-current-job-failures

Conversation

@munezaclovis

Copy link
Copy Markdown
Contributor

Depends on #315 and #318.

Closes #307.

Summary

  • persist typed success/failure outcomes for job diagnostic subjects in completion order
  • resolve only failures covered by newer successful work or a matching healthy observation
  • keep no-op update coverage limited to update assessment
  • reset background error deduplication after verified recovery so identical recurrence is current again
  • make status and doctor share the unresolved-failure policy, timestamps, and focused repair advice
  • refresh verified Gateway health after ports:install or invalidate only PF-derived degradation before reconciliation

Commit structure

  1. state schema and supersession query
  2. daemon coverage recording and recurrence-aware deduplication
  3. status/doctor unresolved failure output
  4. focused PF repair health refresh

Tests

  • cargo test -p state --test state_foundation
  • cargo test -p daemon --lib jobs::tests
  • cargo test -p cli --test status
  • cargo test -p cli --test doctor
  • cargo test -p cli --test ports
  • cargo clippy -p state --all-targets -- -D warnings
  • cargo clippy -p daemon --all-targets -- -D warnings
  • cargo clippy -p cli --all-targets -- -D warnings

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0deb6caf-0fd6-42b1-8ce1-0b67fd86f3a8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codspeed-hq

codspeed-hq Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 7 untouched benchmarks


Comparing agent/resolve-current-job-failures (f2ff12d) with agent/unify-pf-diagnostics (898e44c)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant