Some more bugfixes, documentation, and annotations#203
Merged
Conversation
Report for DPIJ01_PIKIDEMO (ffb7fb6 - 8152e99)No changesReport for GPIJ01_01 (ffb7fb6 - 8152e99)No changesReport for GPIP01_00 (ffb7fb6 - 8152e99)No changesReport for GPIE01_00 (ffb7fb6 - 8152e99)No changesReport for G98E01_PIKIDEMO (ffb7fb6 - 8152e99)No changesReport for G98P01_PIKIDEMO (ffb7fb6 - 8152e99)No changesReport for GPIJ01_02 (ffb7fb6 - 8152e99)No changesReport for GPIE01_01 (ffb7fb6 - 8152e99)No changes |
Thank you Dolphin Emulator
This is typical in other files, and even required in one place for an assertion to compile.
This is atypical for POD structs from Dolphin OS.
This was not legal C++ and messes up GCC.
This macro documents 117 places where damn well nearly every programmer on the staff (but mostly Nakata) wrote illegal C++ code because MetroWerks allows it. Taking the address of an rvalue requires the `-fpermissive` flag in GCC and breaks when optimizations are enabled, so of course it has been affecting my GCC port using CMake. I have left it up to the user to decide how one wishes to address this issue. I have personally found that a combination of placement new and `__builtin_alloca` work great. Most of the places that I added an include for "sysNew.h" already had indirect access to it, I simply made it explicit to ensure this new addition was stable. I might have put this macro in "types.h" if I wasn't planning on using placement new in my downstream fork as a replacement for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From my downstream CMake port.