Skip to content

Deprecate BBB controlpanel adapter.#3735

Draft
jensens wants to merge 2 commits into
masterfrom
jensens-deprecate-controlpanel-bbb
Draft

Deprecate BBB controlpanel adapter.#3735
jensens wants to merge 2 commits into
masterfrom
jensens-deprecate-controlpanel-bbb

Conversation

@jensens

@jensens jensens commented Mar 12, 2023

Copy link
Copy Markdown
Member

Add a deprecation warning to every initialization of all BBB control-panel adapters.

@mister-roboto

Copy link
Copy Markdown

@jensens thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@jensens

jensens commented Mar 12, 2023

Copy link
Copy Markdown
Member Author

@jenkins-plone-org please run jobs

@jensens

jensens commented Mar 29, 2026

Copy link
Copy Markdown
Member Author

Reviving this — it's step 1 in the plan outlined in #1050.

PRs to fix direct getAdapter() callers (step 2) are being prepared:

  • plone.restapi: services/users/add.py and services/users/update.py
  • Products.CMFPlone: controlpanel/browser/usergroups.py

Once those land, these deprecation warnings will help identify any remaining third-party code using the BBB adapter pattern.

@jensens jensens force-pushed the jensens-deprecate-controlpanel-bbb branch from d5172a4 to 2d62cb7 Compare March 29, 2026 23:26
@jensens

jensens commented Mar 29, 2026

Copy link
Copy Markdown
Member Author

@jenkins-plone-org please run jobs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants