Skip to content

Remove all controlpanel BBB adapters.#3734

Closed
jensens wants to merge 1 commit into
masterfrom
drop-controlpanel-bbb-adapter
Closed

Remove all controlpanel BBB adapters.#3734
jensens wants to merge 1 commit into
masterfrom
drop-controlpanel-bbb-adapter

Conversation

@jensens

@jensens jensens commented Mar 12, 2023

Copy link
Copy Markdown
Member

This drops a long deprecated way to work with control-panel data. IMO it can go in Plone 6.1
Lets see if tests are passing and where core may break.
It seems our controlpanel z3c.forms do need to some degree these adapters.

@mister-roboto

Copy link
Copy Markdown

@jensens thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@jensens

jensens commented Mar 12, 2023

Copy link
Copy Markdown
Member Author

@jenkins-plone-org please run jobs

@jensens

jensens commented Mar 29, 2026

Copy link
Copy Markdown
Member Author

Closing in favor of the incremental approach tracked in #1050:

  1. Land Deprecate BBB controlpanel adapter. #3735 first (deprecation warnings on all BBB adapter __init__s)
  2. Fix callers to use registry.forInterface() directly instead of getAdapter(portal, ISchema):
    • plone.restapi: services/users/add.py and services/users/update.py use getAdapter(portal, ISecuritySchema)
    • Products.CMFPlone: controlpanel/browser/usergroups.py uses getAdapter(context, IUserGroupsSettingsSchema)
  3. Address the z3c.form AttributeField data manager implicit adaptation (self.field.interface(context))
  4. Then removal becomes safe

PRs for step 2 are in progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants