Skip to content

fix(chart-release): pass the manifest media type when aliasing charts #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blairham merged 1 commit into from
Jul 2, 2026
Merged

fix(chart-release): pass the manifest media type when aliasing charts #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions .github/workflows/chart-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,14 +202,24 @@ jobs:
# same manifest under a new one. Warn-only: without the
# alias the direct CI notification below still covers the
# release.
# put-image needs the media type passed explicitly: helm's OCI
# manifests omit the optional top-level mediaType field, and
# without it ECR rejects the manifest with a misleading
# "Invalid JSON syntax". jq -j keeps the manifest byte-exact
# (a trailing newline changes the digest and ECR stores a
# second image instead of aliasing); -e fails the pipeline on
# a null lookup instead of passing the literal "null" on.
SHORT_SHA="${GITHUB_SHA:0:7}"
manifest=$(aws ecr batch-get-image --repository-name "charts/${NAME}" \
--image-ids imageTag="${version}" \
--query 'images[0].imageManifest' --output text)
aws ecr put-image --repository-name "charts/${NAME}" \
--image-tag "${version}-${SHORT_SHA}" \
--image-manifest "$manifest" >/dev/null \
|| echo "::warning::sha alias tag failed for charts/${NAME}:${version}-${SHORT_SHA}"
{
aws ecr batch-get-image --repository-name "charts/${NAME}" \
--image-ids imageTag="${version}" --output json \
| jq -ej '.images[0].imageManifest' > manifest.json
aws ecr put-image --repository-name "charts/${NAME}" \
--image-tag "${version}-${SHORT_SHA}" \
--image-manifest "file://manifest.json" \
--image-manifest-media-type "application/vnd.oci.image.manifest.v1+json" \
>/dev/null
} || echo "::warning::sha alias tag failed for charts/${NAME}:${version}-${SHORT_SHA}"

# Tag immediately after successful push (retry up to 3 times).
# If permanent failure the chart sits in ECR with no git tag —
Expand Down