fix(chart-release): pass the manifest media type when aliasing charts - #27
Merged
Conversation
helm's OCI manifests omit the optional top-level mediaType field, and put-image without --image-manifest-media-type rejects them with a misleading "Invalid JSON syntax" — every sha alias since the step landed failed (warn-only, so releases stayed green). Also extract the manifest with jq -ej to a file: -j keeps the bytes exact so ECR aliases the same image instead of storing a trailing-newline variant as a second one, and -e fails the pipeline on a null lookup instead of passing the literal "null" on. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
X.Y.Z-<sha7>alias from feat(release): notify Dispatch directly on publish + chart sha alias #24 never succeeded: helm's OCI manifests omit the optional top-levelmediaType, andput-imagewithout--image-manifest-media-typerejects them with a misleadingInvalid JSON syntax(warn-only, so releases stayed green — understudy run 28622131130 shows the warning).--output json | jq -ejto afile://manifest —-jkeeps the manifest byte-exact so ECR aliases the same image (a trailing newline changes the digest and stores a second image),-ehard-fails on a null lookup instead of passing the literalnulltoput-image.Test plan
charts/understudy:0.0.7— first attempt without media type fails identically to CI; with media type +jq -ejthe alias lands on the same digest (141e02…) anddescribe-imagesshows both tags on one image (0.0.7, 0.0.7-404e9df)actionlintcleansha alias tag failedwarning and the-<sha7>tag appears alongside the version🤖 Generated with Claude Code