Skip to content

ci: tidy pre-existing shellcheck findings + drop -S warning escape hatch #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blairham merged 1 commit into from
Jun 8, 2026
Merged

ci: tidy pre-existing shellcheck findings + drop -S warning escape hatch #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .github/workflows/actionlint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,6 @@ on:
# tightens rules in a way that flags previously-passing workflows.
env:
ACTIONLINT_VERSION: "1.7.7"
# Scope shellcheck to warning+ severity. The gate's job is to catch
# input-contract regressions and real shell bugs (SC2086 quoting,
# SC2046 word-splitting, etc.); info/style nitpicks (SC2295, SC2001,
# SC2129) in long-standing `run:` blocks aren't worth blocking PRs
# over. Drop this once the existing scripts are tidied up.
SHELLCHECK_OPTS: "-S warning"

jobs:
actionlint:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/chart-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ jobs:
if [ -z "$latest" ]; then
candidate="0.0.1"
else
version="${latest#${prefix}}"
version="${latest#"${prefix}"}"
IFS='.' read -r major minor patch <<< "$version"
candidate="${major}.${minor}.$((patch + 1))"
fi
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docker-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ jobs:
if [ -z "$latest_tag" ]; then
major=0; minor=0; patch=0
else
version="${latest_tag#${prefix}}"
version="${latest_tag#"${prefix}"}"
IFS='.' read -r major minor patch <<< "$version"
fi
patch=$((patch + 1))
Expand Down
14 changes: 9 additions & 5 deletions .github/workflows/tag-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,14 @@ jobs:
fi

echo "Services to tag:"
echo "$services" | sed 's/^/ - /'
echo "list<<EOF" >> "$GITHUB_OUTPUT"
echo "$services" >> "$GITHUB_OUTPUT"
echo "EOF" >> "$GITHUB_OUTPUT"
while IFS= read -r svc; do
echo " - $svc"
done <<< "$services"
{
echo "list<<EOF"
echo "$services"
echo "EOF"
} >> "$GITHUB_OUTPUT"

- name: Compute and push tags
if: steps.changed.outputs.list != ''
Expand All @@ -100,7 +104,7 @@ jobs:
next="v0.0.1+${svc}"
else
version="${latest#v}"
version="${version%+${svc}}"
version="${version%+"${svc}"}"
IFS='.' read -r major minor patch <<< "$version"
next="v${major}.${minor}.$((patch + 1))+${svc}"
fi
Expand Down