ci: tidy pre-existing shellcheck findings + drop -S warning escape hatch - #18
Merged
Conversation
Fixes the four info/style findings that PG#944's initial actionlint
roll-out had to suppress via `SHELLCHECK_OPTS=-S warning`:
- chart-release.yml / docker-release.yml: quote the prefix inside
`${var#${prefix}}` (SC2295).
- tag-config.yml: quote `+${svc}` inside `${var%+${svc}}` (SC2295);
group three sequential `>> "$GITHUB_OUTPUT"` redirects under one
`{ ... } >> "$GITHUB_OUTPUT"` (SC2129); replace the `sed`-based
list-prefix with a `while read` loop (SC2001).
With these cleared, the severity override on actionlint.yml's env can
go away too — shellcheck is back to running at its default severity
(`info`+), so future style regressions in `run:` blocks fail PRs.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chart-release.yml,docker-release.yml, andtag-config.ymlthat PG#944's initial roll-out had to suppress.SHELLCHECK_OPTS: -S warningfromactionlint.yml— shellcheck is back at its default severity (info+), so future style regressions inrun:blocks fail PRs.Fixes
${var#${prefix}}→${var#"${prefix}"}(SC2295) in chart-release, docker-release, and tag-config.>> "$GITHUB_OUTPUT"redirects collapsed under one{ ... } >> "$GITHUB_OUTPUT"block in tag-config (SC2129).echo "\$services" | sed 's/^/ - /'replaced with awhile readloop in tag-config (SC2001).Test plan
actionlintjob in this PR's CI is green with noSHELLCHECK_OPTSoverride.🤖 Generated with Claude Code