Skip to content

Serialize Python runner synthesis to prevent cross-request PCM bleed #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
phyceClaw wants to merge 1 commit into
base: python-integration
Choose a base branch
from
Open

Serialize Python runner synthesis to prevent cross-request PCM bleed #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions app/tts/engine/python/process.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,12 @@ type runner struct {

writeMutex sync.Mutex

// synthMutex serializes streamSynth requests on this runner. routeStdout
// routes all stdout to whichever sink is currently attached, so only one
// request may own the sink at a time; otherwise a second attachSink would
// reset routedBytes and steal the first request's PCM.
synthMutex sync.Mutex

format audio.StreamFormat

sinkMutex sync.Mutex
Expand Down Expand Up @@ -341,6 +347,13 @@ func (pythonRunner *runner) load(model string, voicePaths []string) error {
}

func (pythonRunner *runner) streamSynth(ctx context.Context, request runnerRequest, writer *audio.StreamWriter) error {
// Serialize per runner: routeStdout mirrors stdout into the single
// attached sink, so concurrent requests would clobber each other's sink
// and routedBytes. The mutex is held for the whole request and released
// via defer on every return path (including ctx cancellation).
pythonRunner.synthMutex.Lock()
defer pythonRunner.synthMutex.Unlock()

if pythonRunner.exited.Load() {
return pythonRunner.exitFailure()
}
Expand Down