Serialize Python runner synthesis to prevent cross-request PCM bleed#12
Open
phyceClaw wants to merge 1 commit into
Open
Serialize Python runner synthesis to prevent cross-request PCM bleed#12phyceClaw wants to merge 1 commit into
phyceClaw wants to merge 1 commit into
Conversation
routeStdout routes all runner stdout to the currently-attached sink, but concurrent streamSynth calls (dispatchFutures produces futures concurrently) could overlap: the second attachSink reset routedBytes and stole the first request PCM. Serialize synthesis per runner with a dedicated mutex held across a single request. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
routeStdoutroutes all runner stdout to whichever sink is currently attached, but nothing serialized concurrentstreamSynthcalls. SincedispatchFuturesproduces futures concurrently, twoSynthesizecalls on the same Python engine could overlap and the secondattachSinkwould resetroutedBytesand steal the first request PCM.Synthesis is now serialized per runner via a dedicated mutex held across a single request (independent of the engine mutex / restart logic; ctx cancellation still releases it).
Testing
go test -race ./app/tts/engine/python/...passes (includes the cross-request-bleed protocol tests).🤖 Generated with Claude Code