Skip to content

Adds a custom table on tests #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
llrs-roche wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Adds a custom table on tests #337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
93a8890
Add a new table to test further changes on cards
llrs-roche May 14, 2026
eac45e9
Small update to latest roxygen2
llrs-roche May 14, 2026
3d42f37
Fix lintr issue
llrs-roche May 14, 2026
033c839
Add remotes to check the version from github for the thightly coupled…
llrs-roche May 14, 2026
dd35a05
Detect new warnings
llrs-roche May 21, 2026
1096793
Update snapshots
llrs-roche May 21, 2026
7607880
Merge branch 'main' into cards_updates
llrs-roche Jun 19, 2026
4ffa766
Remove unnecessary field
llrs-roche Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Authors@R:
Description: R package with implementation of Safety Tables and Figures
issued by FDA.
License: Apache License (>= 2)
URL: https://github.com/pharmaverse/cardinal/
URL: https://github.com/pharmaverse/cardinal/, https://pharmaverse.github.io/cardinal/
BugReports: https://github.com/pharmaverse/cardinal/issues
Depends:
R (>= 4.2)
Expand Down
1 change: 1 addition & 0 deletions man/cardinal-package.Rd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tests/testthat.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
if (requireNamespace("testthat", quietly = TRUE)) {
library(testthat)

options(warn = 2) # Warnings become errors
pkg_name <- "cardinal"
library(pkg_name, character.only = TRUE)
testthat::test_check(pkg_name)
}

Check warning on line 8 in tests/testthat.R

View workflow job for this annotation

GitHub Actions / SuperLinter 🦸‍♀️ / Lint R code 🧶 

file=tests/testthat.R,line=8,col=1,[trailing_blank_lines_linter] Remove trailing blank lines.
104 changes: 52 additions & 52 deletions tests/testthat/_snaps/fda-table_03.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,58 +113,58 @@
Code
as.data.frame(ard[[2]]$tbl_hierarchical)[1:25, ]
Output
variable variable_level context stat_name
1 ..ard_hierarchical_overall.. TRUE hierarchical n
2 ..ard_hierarchical_overall.. TRUE hierarchical N
3 ..ard_hierarchical_overall.. TRUE hierarchical p
4 SCRNFRS 3 hierarchical n
5 SCRNFRS 3 hierarchical N
6 SCRNFRS 3 hierarchical p
7 SCRNFRS 1 hierarchical n
8 SCRNFRS 1 hierarchical N
9 SCRNFRS 1 hierarchical p
10 SCRNFRS 4 hierarchical n
11 SCRNFRS 4 hierarchical N
12 SCRNFRS 4 hierarchical p
13 SCRNFRS 2 hierarchical n
14 SCRNFRS 2 hierarchical N
15 SCRNFRS 2 hierarchical p
16 ..ard_total_n.. NULL total_n N
NA <NA> NULL <NA> <NA>
NA.1 <NA> NULL <NA> <NA>
NA.2 <NA> NULL <NA> <NA>
NA.3 <NA> NULL <NA> <NA>
NA.4 <NA> NULL <NA> <NA>
NA.5 <NA> NULL <NA> <NA>
NA.6 <NA> NULL <NA> <NA>
NA.7 <NA> NULL <NA> <NA>
NA.8 <NA> NULL <NA> <NA>
stat_label stat stat_fmt
1 n 52 52
2 N 306 306
3 % 0.1699346 17
4 n 11 11
5 N 306 306
6 % 0.03594771 3.6
7 n 17 17
8 N 306 306
9 % 0.05555556 5.6
10 n 7 7
11 N 306 306
12 % 0.02287582 2.3
13 n 17 17
14 N 306 306
15 % 0.05555556 5.6
16 N 306 306
NA <NA> NULL NULL
NA.1 <NA> NULL NULL
NA.2 <NA> NULL NULL
NA.3 <NA> NULL NULL
NA.4 <NA> NULL NULL
NA.5 <NA> NULL NULL
NA.6 <NA> NULL NULL
NA.7 <NA> NULL NULL
NA.8 <NA> NULL NULL
variable variable_level
1 ..ard_hierarchical_overall.. TRUE
2 ..ard_hierarchical_overall.. TRUE
3 ..ard_hierarchical_overall.. TRUE
4 SCRNFRS Consent withdrawn
5 SCRNFRS Consent withdrawn
6 SCRNFRS Consent withdrawn
7 SCRNFRS Inclusion/exclusion criteria not met
8 SCRNFRS Inclusion/exclusion criteria not met
9 SCRNFRS Inclusion/exclusion criteria not met
10 SCRNFRS Other
11 SCRNFRS Other
12 SCRNFRS Other
13 SCRNFRS Subject noncompliance
14 SCRNFRS Subject noncompliance
15 SCRNFRS Subject noncompliance
16 ..ard_total_n.. NULL
NA <NA> NULL
NA.1 <NA> NULL
NA.2 <NA> NULL
NA.3 <NA> NULL
NA.4 <NA> NULL
NA.5 <NA> NULL
NA.6 <NA> NULL
NA.7 <NA> NULL
NA.8 <NA> NULL
context stat_name stat_label stat stat_fmt
1 hierarchical n n 52 52
2 hierarchical N N 306 306
3 hierarchical p % 0.1699346 17
4 hierarchical n n 11 11
5 hierarchical N N 306 306
6 hierarchical p % 0.03594771 3.6
7 hierarchical n n 17 17
8 hierarchical N N 306 306
9 hierarchical p % 0.05555556 5.6
10 hierarchical n n 7 7
11 hierarchical N N 306 306
12 hierarchical p % 0.02287582 2.3
13 hierarchical n n 17 17
14 hierarchical N N 306 306
15 hierarchical p % 0.05555556 5.6
16 total_n N N 306 306
NA <NA> <NA> <NA> NULL NULL
NA.1 <NA> <NA> <NA> NULL NULL
NA.2 <NA> <NA> <NA> NULL NULL
NA.3 <NA> <NA> <NA> NULL NULL
NA.4 <NA> <NA> <NA> NULL NULL
NA.5 <NA> <NA> <NA> NULL NULL
NA.6 <NA> <NA> <NA> NULL NULL
NA.7 <NA> <NA> <NA> NULL NULL
NA.8 <NA> <NA> <NA> NULL NULL
fmt_fun
1 function (x) , style_number(x, digits = digits, big.mark = big.mark, decimal.mark = decimal.mark, , scale = scale, prefix = prefix, suffix = suffix, na = na, , ...)
2 function (x) , style_number(x, digits = digits, big.mark = big.mark, decimal.mark = decimal.mark, , scale = scale, prefix = prefix, suffix = suffix, na = na, , ...)
Expand Down
Loading
Loading