Adds a custom table on tests#337
Open
llrs-roche wants to merge 8 commits into
Open
Conversation
Contributor
Author
|
@shajoezhu This implements a custom table but adding the "Remotes:" to use the latest development version of the cards and other packages show that the recent warning added on cards shows also in old templates: https://github.com/pharmaverse/cardinal/actions/runs/25852849902/job/75963357337?pr=337#step:44:222 
|
11 tasks
Contributor
Author
|
I compared the renv.lock and the session information of CRAN and NON-CRAN checks and I couldn't find any difference. I'm not sure what causes the snapshots to change and the tests to fail on that case. Let me know if I need to research that deeper |
Collaborator
|
So many changes are unrelated to the addition. Could you track down the source?? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
This was a request to increase the test coverage of cards in new tables.
Locally I see some changes on the snapshot of templates I haven't modified. Might be caught on scheduled test.