fix: replace Docker build with native asciidoctor install in any-branch-uploads - #1410
fix: replace Docker build with native asciidoctor install in any-branch-uploads#1410Devansh-567 wants to merge 1 commit into
Conversation
…ch-uploads Signed-off-by: Devansh-567 <devansh.jay.singh@gmail.com>
4806f31 to
e4238ab
Compare
|
Out of curiosity, does the p4lang/p4runtime repository use a different docker image than the p4-spec repo is, or is it a different one? https://github.com/p4lang/p4runtime/blob/main/.github/workflows/main-branch-uploads.yml#L20 |
Yes, they are different images. The p4-spec repo was using p4lang/p4-spec-asciidoc:latest while p4runtime uses p4lang/p4rt-asciidoc. Both are separate Docker images. The p4runtime workflow at that link still uses the Docker-based approach, it might be worth applying the same native install approach there as well if consistency is desired, but that would be a separate PR in the p4lang/p4runtime repository. |
|
This is ready to merge whenever you have a chance. Thanks for the review! |
|
@rcgoodfellow Any preferences on this? I do not recall the source or work flow used to create the Docker image that is currently used to build the Asciidoc source of the spec documents. This PR stops using that Docker image, instead installing Asciidoctor on each CI run. It takes a little bit of time on the CI machine, but the whole process is still at most 5 minutes long, so seems reasonable to me. |
Closes #1404
The any-branch-uploads workflow used a Docker image
p4lang/p4-spec-asciidoc:latest whose source is not publicly visible,
making the build environment difficult to audit.
This replaces the Docker-based build with the same native
install-asciidoctor-linux.sh approach used in asciidoc-build.yml,
making both workflows consistent and fully auditable.
Also updates actions/checkout from v3 to v4 and pins
ubuntu-latest to ubuntu-24.04 for reproducibility.