Skip to content

Remove Dockerfiles that are no longer used - #1412

Open
Devansh-567 wants to merge 2 commits into
p4lang:mainfrom
Devansh-567:fix/dockerfile-gem-install-chaining
Open

Remove Dockerfiles that are no longer used#1412
Devansh-567 wants to merge 2 commits into
p4lang:mainfrom
Devansh-567:fix/dockerfile-gem-install-chaining

Conversation

@Devansh-567

Copy link
Copy Markdown
Contributor

Both tools/Dockerfile.asciidoc_v1 and tools/Dockerfile.asciidoc_v2
had broken RUN command chaining in the gem install and rouge build
steps.

Issues fixed:

  • gem install commands used \ (line continuation) instead of &&\,
    meaning failures would be silently ignored and subsequent installs
    would still run
  • cd rouge \ did not persist to the next line, so gem build and
    gem install were running in the wrong directory
  • Replaced hardcoded rouge-4.4.0.gem with rouge-*.gem wildcard
    to match whatever version was built from source

These bugs would cause the Docker image to silently produce an
incorrect build environment.

Signed-off-by: Devansh-567 <devansh.jay.singh@gmail.com>
@jafingerhut

Copy link
Copy Markdown
Collaborator

Since you recently made changes so that the Docker images are not used to run asciidoctor, I guess the bigger question is whether there is any reason to keep these files around any longer, or should they just be removed?

@Devansh-567

Copy link
Copy Markdown
Contributor Author

Since you recently made changes so that the Docker images are not used to run asciidoctor, I guess the bigger question is whether there is any reason to keep these files around any longer, or should they just be removed?

That's a fair point. Since the any-branch-uploads.yml workflow no longer uses the Docker image, these Dockerfiles appear to have no remaining users in the repository. I am happy to replace this PR with one that removes both files entirely if that is preferred. Just let me know and I will update the branch

@jafingerhut

jafingerhut commented May 26, 2026

Copy link
Copy Markdown
Collaborator

Since you recently made changes so that the Docker images are not used to run asciidoctor, I guess the bigger question is whether there is any reason to keep these files around any longer, or should they just be removed?

That's a fair point. Since the any-branch-uploads.yml workflow no longer uses the Docker image, these Dockerfiles appear to have no remaining users in the repository. I am happy to replace this PR with one that removes both files entirely if that is preferred. Just let me know and I will update the branch

Please do, and thanks. I'd rather not maintain scripts that likely no one is using now, nor likely to use in the future.

Signed-off-by: Devansh-567 <devansh.jay.singh@gmail.com>
@jafingerhut jafingerhut changed the title fix: correct RUN command chaining in Dockerfiles Remove Dockerfiles that are no longer used May 27, 2026
@Devansh-567

Copy link
Copy Markdown
Contributor Author

This is ready to merge whenever you have a chance. Thanks for the review!

@jafingerhut

Copy link
Copy Markdown
Collaborator

This is ready to merge whenever you have a chance. Thanks for the review!

It seems best to wait to merge this until after #1410 is approved and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants