feat(core): define handler contract and extract statusHandler

[galligan]

Summary

• Define HandlerContext and Handler<TInput, TOutput, TError> in packages/core/src/handlers/types.ts
• Extract statusHandler as first transport-agnostic handler with Result<StatusOutput, Error> return
• Wire CLI status command and MCP fw_status tool to shared handler
• Add tests for getCacheStats (empty, populated, multi-repo scenarios) (FIRE-4)

Test plan

• bun run check passes
• bun test passes (288 tests)
• bun apps/cli/bin/fw.ts status --short returns valid JSON

🤘🏻 In-collaboration-with: Claude Code

Greptile Summary

Extracts status logic into a transport-agnostic statusHandler that both CLI and MCP can consume, eliminating ~200 lines of duplication.

• Defines HandlerContext (config, db, logger) and Handler<TInput, TOutput, TError> contract in packages/core/src/handlers/types.ts
• Implements statusHandler that gathers auth, config, repo, Graphite, and cache info and returns Result<StatusOutput, Error>
• Extracts getCacheStats helper for querying repos, entries, and last sync time from the database
• Refactors CLI status command to delegate to statusHandler, removing all duplicate logic
• Refactors MCP fw_status tool to use statusHandler, removing duplicate getCacheStats implementation
• Adds comprehensive tests covering empty, populated, and multi-repo scenarios
• Adds @outfitter/firewatch-shared dependency to CLI and MCP packages for silentLogger import

Confidence Score: 5/5

• This PR is safe to merge with no issues found
• Clean refactoring with comprehensive test coverage (288 tests pass), eliminates code duplication, follows established patterns, and all test plan items verified
• No files require special attention

Important Files Changed

Filename	Overview
packages/core/src/handlers/types.ts	Defines HandlerContext and Handler<TInput, TOutput, TError> types for transport-agnostic handlers
packages/core/src/handlers/status.ts	Implements statusHandler with getCacheStats helper, returns structured StatusOutput
packages/core/tests/handlers/status.test.ts	Comprehensive tests for getCacheStats and statusHandler covering empty, populated, and multi-repo scenarios
apps/cli/src/commands/status.ts	Refactored to use statusHandler, removed 150+ lines of duplicate logic
apps/mcp/src/index.ts	Refactored fw_status tool to use shared statusHandler, removed duplicate getCacheStats

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[CLI status command] -->|calls| H[statusHandler]
    B[MCP fw_status tool] -->|calls| H
    H -->|receives| C[HandlerContext]
    C -->|contains| D[config: FirewatchConfig]
    C -->|contains| E[db: Database]
    C -->|contains| F[logger: Logger]
    H -->|calls| G[getCacheStats]
    G -->|queries| E
    H -->|calls| I[detectAuth]
    H -->|calls| J[detectRepo]
    H -->|calls| K[getGraphiteStacks]
    H -->|returns| L[Result<StatusOutput, Error>]
    L -->|CLI formats| M[Console output or JSON]
    L -->|MCP formats| N[MCP tool response]

Loading

_{Last reviewed commit: f07a741}

[linear]

FIRE-4 Define handler contract pattern with template extraction

[galligan]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• docs: update architecture docs for Outfitter stack adoption #172
• feat(mcp): adopt @outfitter/mcp with createMcpServer() and defineTool() #171
• refactor(cli): wire exitWithError() across key commands #170
• feat(cli): adopt @outfitter/cli with createCLI() entry point #169
• feat(core): extract sync handler #168
• feat(core): extract PR mutation handlers (approve, reject, edit) #167
• feat(core): extract feedback handlers (reply, comment, ack, close) #166
• feat(core): extract read handlers (doctor, query) #165
• feat(core): define handler contract and extract statusHandler #164 👈 (View in Graphite)
• chore(core): upgrade @outfitter/contracts to ^0.4.1 #163
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f07a74114c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Compute cache size from ctx.db instead of global PATHS.db

This handler is intended to be transport-agnostic, but it always reads PATHS.db for size_bytes while counts come from ctx.db. When callers pass an in-memory or non-default database (as tests and future transports can), status output can combine repo/entry counts from one database with file size from another, producing incorrect cache telemetry and violating the handler contract.

Useful? React with 👍 / 👎.