Skip to content

chore(core): upgrade @outfitter/contracts to ^0.4.1#163

Open
galligan wants to merge 1 commit into
mainfrom
fire-3/contracts-upgrade
Open

chore(core): upgrade @outfitter/contracts to ^0.4.1#163
galligan wants to merge 1 commit into
mainfrom
fire-3/contracts-upgrade

Conversation

@galligan

@galligan galligan commented Feb 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Bump @outfitter/contracts from ^0.1.0 to ^0.4.1 in core and shared
  • Update createLogger to satisfy new LogMethod overloaded interface
  • Foundation PR for the Outfitter stack adoption series (FIRE-3)

Test plan

  • bun install succeeds
  • bun run check passes (lint + types)
  • bun test passes (288 tests)

🤘🏻 In-collaboration-with: Claude Code

Greptile Summary

This PR upgrades @outfitter/contracts from ^0.1.0 to ^0.4.1 across the core and shared packages. The logger implementation was refactored to satisfy the new LogMethod interface by extracting a helper method pattern and adding subpath imports (@outfitter/contracts/logging).

  • Updated dependency versions in packages/core/package.json and packages/shared/package.json
  • Refactored createLogger to use a method() helper that wraps log calls and returns properly typed LogMethod instances
  • Added type imports for LogMetadata and LogMethod from the contracts package
  • Changed from default import to subpath import (@outfitter/contracts/logging)
  • All tests pass (288 tests) and type checking succeeds according to PR description

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The changes are straightforward dependency upgrades with appropriate code updates to match the new interface. The PR author verified that all tests pass (288 tests), type checking succeeds, and build completes successfully. The refactoring to the logger implementation is clean and maintains backward compatibility since the Logger interface hasn't changed from a consumer perspective.
  • No files require special attention

Important Files Changed

Filename Overview
packages/core/package.json Upgraded @outfitter/contracts from ^0.1.0 to ^0.4.1 as specified in the PR description
packages/shared/package.json Upgraded @outfitter/contracts from ^0.1.0 to ^0.4.1 consistently with core package
packages/shared/src/logger.ts Refactored to use new LogMethod interface with subpath imports and helper method pattern

Last reviewed commit: 0e25df7

Bump contracts from ^0.1.0 to ^0.4.1 in core and shared packages.

The Logger interface changed to use overloaded LogMethod (message-first
with metadata-first resolving to never for compile-time misuse detection).
Updated createLogger to produce properly typed LogMethod instances.

Remaining throws in sync.ts (line 540) and config.ts (lines 24, 152) are
boundary validation checks — correct as-is per assessment.

🤘🏻 In-collaboration-with: [Claude Code](https://claude.com/claude-code)
@linear

linear Bot commented Feb 22, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant