Fix #6259: Add failure tracking to static_checks.sh by adanaamir · Pull Request #6289 · oppia/oppia-android

adanaamir · 2026-06-23T08:40:24Z

This PR supersedes #6287, which was automatically closed after a force push.

Summary

Adds failure tracking to scripts/static_checks.sh so that all checks continue running to completion while the script exits with a non-zero status code if any check fails.

Testing

Verified that failed checks increment the failure counter
Verified that all checks continue running even when a check fails
Verified that the script reports the total number of failures
Verified that the script exits with a non-zero status code when failures occur

coderabbitai · 2026-06-23T08:40:32Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 30e3fb00-ff55-43c2-b946-dfe5927f812a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-06-23T08:42:31Z

@adanaamir this PR is being marked as draft because the PR description must contain 'Fixes #' or 'Fixes part of #' for each issue the PR is changing, and each one on its own line with no other text.

github-actions · 2026-06-23T09:02:35Z

@adanaamir this PR is being marked as draft because you are not assigned to referenced issue #6259 (or it does not exist). You may only fix issues that you are assigned to to help avoid multiple team members duplicating work on the same issue.

Sandesh282 · 2026-06-23T19:15:42Z

@adanaamir You need to sign the CLA before contributing to Oppia, which is why the checks are failing. As I mentioned earlier, please go through the contributing guidelines once. They cover these basic contribution requirements and help avoid issues like this.

PS: Once the CLA is signed, you can request a review by commenting "@reviewer_name, PTAL", and the bot will automatically assign the reviewer.

adanaamir · 2026-06-24T10:16:03Z

@manas-yu , PTAL

github-actions · 2026-06-24T11:21:28Z

Coverage Report

Results

Coverage Analysis: SKIP ⏭️

This PR did not introduce any changes to Kotlin source or test files.

To learn more, visit the Oppia Android Code Coverage wiki page

Sandesh282

Hi @adanaamir, looks good overall! Just one thought below. PTAL!

Sandesh282 · 2026-06-27T18:25:35Z

+# License Texts Check
+echo "********************************"
+echo "Running license texts checks"
+echo "********************************"
+bazel run //scripts:license_texts_check -- $(pwd)/app/src/main/res/values/third_party_dependencies.xml || FAILURES=$((FAILURES+1))
 echo ""


Quick Question: This is a net-new check being introduced in the same PR as the failure tracking infrastructure. Was this intentional or a separate change that snuck in? If intentional, it should probably be called out explicitly in the PR description since the title only mentions failure tracking.

Thanks for pointing this out, I didn't actually write or intend to introduce the License Texts Check. It was already present on develop and got pulled into my branch when I resolved the merge conflict. If you say, I'll remove it from this PR so it only contains the failure tracking changes.

Looks like your merge didn't pick up the latest develop: PR #6265 removed the License Texts Check after you branched off. So, yeah you might wanna clean up that in next commit.

Sandesh282 · 2026-06-27T19:00:19Z

@adanaamir The CI is failing due to # TODO checks.
TODOs should be formatted as actual TODO comments, e.g.:

# TODO(#12345): Fix problem.

And should always point to an actual filed issue. Otherwise, our tooling and team processes are unlikely to track the work and ensure it eventually gets done.

You can assign me back using "@reviewer_name, PTAL!" when CI is green, or if you need further help.

adanaamir · 2026-06-28T07:36:32Z

@Sandesh282 , CI is green, PTAL.

oppiabot · 2026-06-28T07:39:37Z

Unassigning @adanaamir since a re-review was requested. @adanaamir, please make sure you have addressed all review comments. Thanks!

Sandesh282

Thanks @adanaamir! This LGTM!

Sandesh282 · 2026-07-01T15:25:10Z

@adanaamir The maintainers will be busy for a week or two. Please wait in the meantime.

manas-yu · 2026-07-01T18:34:10Z

LGTM @adanaamir, Thanks @Sandesh282 for the review as well.

@adhiamboperes or @BenHenning will merge the PR once they are available, @adanaamir feel free to work on other issues in the meantime

oppiabot · 2026-07-01T18:38:06Z

Hi @adanaamir, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks!

github-actions · 2026-07-02T05:20:51Z

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 19 MiB (old), 19 MiB (new), 47 KiB (Removed)

APK download size (estimated): 18 MiB (old), 18 MiB (new), 41 KiB (Removed)

Method count: 266903 (old), 266005 (new), 898 (Removed)

Features: 1 (old), 1 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 7149 (old), 7119 (new), 30 (Removed)

Anim: 43 (old), 43 (new), 0 (No change)
Animator: 26 (old), 26 (new), 0 (No change)
Array: 15 (old), 15 (new), 0 (No change)
Attr: 922 (old), 922 (new), 0 (No change)
Bool: 9 (old), 9 (new), 0 (No change)
Color: 1012 (old), 1005 (new), 7 (Removed):
- color/color_def_silver_grey (removed)
- color/color_palette_lesson_progress_indicator_node_background_color (removed)
- color/color_palette_lesson_progress_indicator_reached_color (removed)
- color/color_palette_lesson_progress_indicator_upcoming_color (removed)
- color/component_color_lesson_progress_indicator_node_background_color (removed)
- And 2 others
Dimen: 1094 (old), 1093 (new), 1 (Removed):
- dimen/study_guide_fragment_padding_bottom (removed)
Drawable: 393 (old), 393 (new), 0 (No change)
Id: 1378 (old), 1363 (new), 15 (Removed):
- id/lesson_progress_indicator (removed)
- id/study_guide_continue_studying_text_view (removed)
- id/study_guide_fragment_placeholder (removed)
- id/study_guide_navigation_card_container (removed)
- id/study_guide_next_navigation_card (removed)
- And 10 others
Integer: 37 (old), 37 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 406 (old), 401 (new), 5 (Removed):
- layout/lesson_progress_indicator_item (removed)
- layout/study_guide_activity (removed)
- layout/study_guide_fragment (removed)
- layout/study_guide_section_content (removed)
- layout/study_guide_section_heading (removed)
Menu: 3 (old), 3 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
Raw: 2 (old), 2 (new), 0 (No change)
String: 940 (old), 938 (new), 2 (Removed):
- string/lesson_progress_indicator_content_description (removed)
- string/study_guide_activity_title (removed)
Style: 840 (old), 840 (new), 0 (No change)
Xml: 7 (old), 7 (new), 0 (No change)

Lesson assets: 69 (old), 69 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 19 MiB (old), 19 MiB (new), 47 KiB (Removed)
APK download size (estimated): 18 MiB (old), 18 MiB (new), 44 KiB (Removed)
Method count: 266903 (old), 266005 (new), 898 (Removed)
Resources: 7099 (old), 7069 (new), 30 (Removed)

Color: 1012 (old), 1005 (new), 7 (Removed)
Dimen: 1090 (old), 1089 (new), 1 (Removed)
Id: 1378 (old), 1363 (new), 15 (Removed)
Layout: 406 (old), 401 (new), 5 (Removed)
String: 940 (old), 938 (new), 2 (Removed)

Configuration hdpi

APK file size: 50 KiB (old), 50 KiB (new), 4 bytes (Removed)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 2 bytes (Added)

Configuration ldpi

APK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 46 KiB (old), 46 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 1 bytes (Added)

Configuration tvdpi

APK file size: 86 KiB (old), 86 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 1 bytes (Added)

Configuration xhdpi

APK file size: 57 KiB (old), 57 KiB (new), 4 bytes (Removed)
APK download size (estimated): 21 KiB (old), 21 KiB (new), 2 bytes (Added)

Configuration xxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 4 bytes (Removed)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 8 bytes (Removed)

Configuration xxxhdpi

APK file size: 64 KiB (old), 64 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 6 bytes (Removed)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 32 KiB (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 28 KiB (Removed)

Method count: 119174 (old), 118719 (new), 455 (Removed)

Features: 1 (old), 1 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6084 (old), 6054 (new), 30 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 860 (old), 853 (new), 7 (Removed):
- color/color_def_silver_grey (removed)
- color/color_palette_lesson_progress_indicator_node_background_color (removed)
- color/color_palette_lesson_progress_indicator_reached_color (removed)
- color/color_palette_lesson_progress_indicator_upcoming_color (removed)
- color/component_color_lesson_progress_indicator_node_background_color (removed)
- And 2 others
Dimen: 816 (old), 815 (new), 1 (Removed):
- dimen/study_guide_fragment_padding_bottom (removed)
Drawable: 355 (old), 355 (new), 0 (No change)
Id: 1319 (old), 1304 (new), 15 (Removed):
- id/lesson_progress_indicator (removed)
- id/study_guide_continue_studying_text_view (removed)
- id/study_guide_fragment_placeholder (removed)
- id/study_guide_navigation_card_container (removed)
- id/study_guide_next_navigation_card (removed)
- And 10 others
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 364 (old), 359 (new), 5 (Removed):
- layout/lesson_progress_indicator_item (removed)
- layout/study_guide_activity (removed)
- layout/study_guide_fragment (removed)
- layout/study_guide_section_content (removed)
- layout/study_guide_section_heading (removed)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 861 (old), 859 (new), 2 (Removed):
- string/lesson_progress_indicator_content_description (removed)
- string/study_guide_activity_title (removed)
Style: 486 (old), 486 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 70 (old), 70 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 32 KiB (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 27 KiB (Removed)
Method count: 119174 (old), 118719 (new), 455 (Removed)
Resources: 6041 (old), 6011 (new), 30 (Removed)

Color: 860 (old), 853 (new), 7 (Removed)
Dimen: 814 (old), 813 (new), 1 (Removed)
Id: 1319 (old), 1304 (new), 15 (Removed)
Layout: 364 (old), 359 (new), 5 (Removed)
String: 861 (old), 859 (new), 2 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 4 bytes (Removed)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 2 bytes (Added)

Configuration ldpi

APK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 1 bytes (Removed)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 1 bytes (Added)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 3 bytes (Removed)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 4 bytes (Removed)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 3 bytes (Added)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 5 bytes (Added)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 4 bytes (Removed)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 4 bytes (Removed)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 32 KiB (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 26 KiB (Removed)

Method count: 119181 (old), 118726 (new), 455 (Removed)

Features: 1 (old), 1 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6084 (old), 6054 (new), 30 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 860 (old), 853 (new), 7 (Removed):
- color/color_def_silver_grey (removed)
- color/color_palette_lesson_progress_indicator_node_background_color (removed)
- color/color_palette_lesson_progress_indicator_reached_color (removed)
- color/color_palette_lesson_progress_indicator_upcoming_color (removed)
- color/component_color_lesson_progress_indicator_node_background_color (removed)
- And 2 others
Dimen: 816 (old), 815 (new), 1 (Removed):
- dimen/study_guide_fragment_padding_bottom (removed)
Drawable: 355 (old), 355 (new), 0 (No change)
Id: 1319 (old), 1304 (new), 15 (Removed):
- id/lesson_progress_indicator (removed)
- id/study_guide_continue_studying_text_view (removed)
- id/study_guide_fragment_placeholder (removed)
- id/study_guide_navigation_card_container (removed)
- id/study_guide_next_navigation_card (removed)
- And 10 others
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 364 (old), 359 (new), 5 (Removed):
- layout/lesson_progress_indicator_item (removed)
- layout/study_guide_activity (removed)
- layout/study_guide_fragment (removed)
- layout/study_guide_section_content (removed)
- layout/study_guide_section_heading (removed)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 861 (old), 859 (new), 2 (Removed):
- string/lesson_progress_indicator_content_description (removed)
- string/study_guide_activity_title (removed)
Style: 486 (old), 486 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 70 (old), 70 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 32 KiB (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 28 KiB (Removed)
Method count: 119181 (old), 118726 (new), 455 (Removed)
Resources: 6041 (old), 6011 (new), 30 (Removed)

Color: 860 (old), 853 (new), 7 (Removed)
Dimen: 814 (old), 813 (new), 1 (Removed)
Id: 1319 (old), 1304 (new), 15 (Removed)
Layout: 364 (old), 359 (new), 5 (Removed)
String: 861 (old), 859 (new), 2 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 4 bytes (Removed)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 5 bytes (Added)

Configuration ldpi

APK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 1 bytes (Added)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 1 bytes (Added)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 4 bytes (Removed)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 2 bytes (Added)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 4 bytes (Added)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 4 bytes (Removed)
APK download size (estimated): 28 KiB (old), 27 KiB (new), 6 bytes (Removed)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 32 KiB (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 26 KiB (Removed)

Method count: 119181 (old), 118726 (new), 455 (Removed)

Features: 1 (old), 1 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6084 (old), 6054 (new), 30 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 860 (old), 853 (new), 7 (Removed):
- color/color_def_silver_grey (removed)
- color/color_palette_lesson_progress_indicator_node_background_color (removed)
- color/color_palette_lesson_progress_indicator_reached_color (removed)
- color/color_palette_lesson_progress_indicator_upcoming_color (removed)
- color/component_color_lesson_progress_indicator_node_background_color (removed)
- And 2 others
Dimen: 816 (old), 815 (new), 1 (Removed):
- dimen/study_guide_fragment_padding_bottom (removed)
Drawable: 355 (old), 355 (new), 0 (No change)
Id: 1319 (old), 1304 (new), 15 (Removed):
- id/lesson_progress_indicator (removed)
- id/study_guide_continue_studying_text_view (removed)
- id/study_guide_fragment_placeholder (removed)
- id/study_guide_navigation_card_container (removed)
- id/study_guide_next_navigation_card (removed)
- And 10 others
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 364 (old), 359 (new), 5 (Removed):
- layout/lesson_progress_indicator_item (removed)
- layout/study_guide_activity (removed)
- layout/study_guide_fragment (removed)
- layout/study_guide_section_content (removed)
- layout/study_guide_section_heading (removed)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 861 (old), 859 (new), 2 (Removed):
- string/lesson_progress_indicator_content_description (removed)
- string/study_guide_activity_title (removed)
Style: 486 (old), 486 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 70 (old), 70 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 32 KiB (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 28 KiB (Removed)
Method count: 119181 (old), 118726 (new), 455 (Removed)
Resources: 6041 (old), 6011 (new), 30 (Removed)

Color: 860 (old), 853 (new), 7 (Removed)
Dimen: 814 (old), 813 (new), 1 (Removed)
Id: 1319 (old), 1304 (new), 15 (Removed)
Layout: 364 (old), 359 (new), 5 (Removed)
String: 861 (old), 859 (new), 2 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 4 bytes (Removed)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 3 bytes (Added)

Configuration ldpi

APK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 1 bytes (Removed)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 1 bytes (Added)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 2 bytes (Removed)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 4 bytes (Removed)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 1 bytes (Removed)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 1 bytes (Added)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 4 bytes (Removed)
APK download size (estimated): 28 KiB (old), 27 KiB (new), 5 bytes (Removed)

oppiabot · 2026-07-09T06:12:54Z

Hi @adanaamir, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you! If you're unsure how to reassign this PR to a reviewer, please make sure to review the wiki page that details the Guidance on submitting PRs.

oppiabot · 2026-07-16T08:50:08Z

Hi @adanaamir, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you! If you're unsure how to reassign this PR to a reviewer, please make sure to review the wiki page that details the Guidance on submitting PRs.

oppiabot · 2026-07-23T10:49:34Z

Hi @adanaamir, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you! If you're unsure how to reassign this PR to a reviewer, please make sure to review the wiki page that details the Guidance on submitting PRs.

adhiamboperes

Thanks @adanaamir!

One additional improvement to consider: instead of only tracking the number of failures, you could also keep a list of the checks that failed and print it at the end. This would make it much easier for developers to quickly identify which checks need attention, especially since the script continues running after a failure.

For example, you could maintain an array such as FAILED_CHECKS, append the check name whenever a command fails, and then print a summary before exiting:

FAILED_CHECKS+=("Ktlint")

Resulting in output like:

2 check(s) failed:
  - Ktlint
  - XML syntax validation

This keeps the existing behavior of running all checks while providing a clearer summary of what actually failed.

oppiabot · 2026-07-23T12:03:32Z

Hi, @adanaamir, the LGTM Label has been removed because the changes were requested on this PR. Thanks!.

adhiamboperes · 2026-07-23T13:26:10Z

Additionally, please fix the PR template, the Essential Checklist section is missing.

Fix oppia#6259: Add failure tracking to static_checks.sh

7380124

adanaamir requested a review from a team as a code owner June 23, 2026 08:40

adanaamir requested a review from manas-yu June 23, 2026 08:40

github-actions Bot marked this pull request as draft June 23, 2026 08:42

adanaamir mentioned this pull request Jun 23, 2026

[Feature Request]: Add missing exit-code propagation to scripts/static_checks.sh #6259

Open

adanaamir marked this pull request as ready for review June 23, 2026 08:46

github-actions Bot marked this pull request as draft June 23, 2026 09:02

adanaamir marked this pull request as ready for review June 23, 2026 11:18

Sandesh282 marked this pull request as draft June 23, 2026 19:09

Sandesh282 marked this pull request as ready for review June 23, 2026 19:09

Sandesh282 closed this Jun 24, 2026

Sandesh282 reopened this Jun 24, 2026

Merge branch 'develop' into fix-static-checks-exit-code

2541f58

Sandesh282 requested changes Jun 27, 2026

View reviewed changes

Sandesh282 assigned adanaamir Jun 27, 2026

Remove unintended merge changes

177d481

oppiabot Bot assigned Sandesh282 and unassigned adanaamir Jun 28, 2026

adanaamir requested a review from Sandesh282 June 28, 2026 08:24

Sandesh282 approved these changes Jun 28, 2026

View reviewed changes

oppiabot Bot unassigned Sandesh282 Jun 28, 2026

manas-yu enabled auto-merge (squash) July 1, 2026 18:34

manas-yu approved these changes Jul 1, 2026

View reviewed changes

manas-yu assigned BenHenning and adhiamboperes and unassigned manas-yu Jul 1, 2026

oppiabot Bot added the PR: LGTM label Jul 1, 2026

oppiabot Bot assigned adanaamir Jul 1, 2026

oppiabot Bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jul 9, 2026

Neer-rn removed the PR: LGTM label Jul 9, 2026

oppiabot Bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jul 9, 2026

Neer-rn unassigned adanaamir Jul 9, 2026

Neer-rn added the PR: LGTM label Jul 9, 2026

oppiabot Bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jul 16, 2026

Neer-rn removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jul 16, 2026

oppiabot Bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jul 23, 2026

adhiamboperes unassigned BenHenning Jul 23, 2026

oppiabot Bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jul 23, 2026

adhiamboperes requested changes Jul 23, 2026

View reviewed changes

adhiamboperes assigned adanaamir and unassigned adhiamboperes Jul 23, 2026

oppiabot Bot removed the PR: LGTM label Jul 23, 2026

Uh oh!

Conversation

adanaamir commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Uh oh!

coderabbitai Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

github-actions Bot commented Jun 23, 2026

Uh oh!

github-actions Bot commented Jun 23, 2026

Uh oh!

Sandesh282 commented Jun 23, 2026

Uh oh!

adanaamir commented Jun 24, 2026

Uh oh!

github-actions Bot commented Jun 24, 2026

Coverage Report

Results

Uh oh!

Sandesh282 left a comment

Choose a reason for hiding this comment

Uh oh!

Sandesh282 Jun 27, 2026

Choose a reason for hiding this comment

Uh oh!

adanaamir Jun 27, 2026

Choose a reason for hiding this comment

Uh oh!

Sandesh282 Jun 27, 2026

Choose a reason for hiding this comment

Uh oh!

Sandesh282 commented Jun 27, 2026

Uh oh!

adanaamir commented Jun 28, 2026

Uh oh!

oppiabot Bot commented Jun 28, 2026

Uh oh!

Sandesh282 left a comment

Choose a reason for hiding this comment

Uh oh!

Sandesh282 commented Jul 1, 2026

Uh oh!

manas-yu commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oppiabot Bot commented Jul 1, 2026

Uh oh!

github-actions Bot commented Jul 2, 2026

APK & AAB differences analysis

Dev

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Alpha

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Beta

Universal APK

AAB differences

Base APK

Configuration hdpi

adanaamir commented Jun 23, 2026 •

edited

Loading

coderabbitai Bot commented Jun 23, 2026 •

edited

Loading

manas-yu commented Jul 1, 2026 •

edited

Loading