[Feature Request]: Add missing exit-code propagation to `scripts/static_checks.sh`

[Sandesh282]

Is your feature request related to a problem? Please describe.

scripts/static_checks.sh is the local "run all checks" convenience script. However, when an individual check fails (e.g., ktlint_lint_check.sh exits with code 1), the outer script currently continues running the next check and ultimately exits with the status of the last command, not the first failure. This means a developer could see "finished" at the end while a check in the middle silently failed.

The fix is to track failures across all checks and exit with a non-zero code if any of them failed, matching CI behavior.

Describe the solution you'd like

Update scripts/static_checks.sh to track failures across all checks and exit with a non-zero code if any of them failed, while still running all checks to completion (not bailing on the first failure).

Concretely:

• Add a FAILURES=0 counter at the top of the script.
• After each check invocation, append || FAILURES=$((FAILURES+1)) to capture failures without stopping execution.
• At the very end of the script, exit with a non-zero code if FAILURES > 0 and print a clear summary, e.g.:
  • 2 check(s) failed. Please fix the above errors.
  • All checks passed.

This matches how CI behaves: all checks run, and the job reports overall failure if any individual step failed.

Describe alternatives you've considered

Using set -e at the top of the script would bail on the first failure and skip remaining checks, which is worse UX for a developer who wants to fix all issues in one pass. The failure-counter approach is strictly better.

Additional context

Files involved:

• scripts/static_checks.sh (only file that needs to change)

The fix is ~10 lines of Bash. A contributor can verify correctness by:

1. Introducing a deliberate lint error (e.g. a trailing space in a .kt file).
2. Running bash scripts/static_checks.sh.
3. Confirming the script completes all remaining checks AND exits with code 1.

Related: scripts/pre-push.sh already has a similar pattern worth referencing.

[adanaamir]

Hi! I have already implemented a fix for this issue and opened PR #6287. Since this issue currently has no assignee, could I please be assigned to it? Thank you!

[adhiamboperes]

Hi @adanaamir, could you please give us a brief explanation of your proposed implementation? cc/ @Sandesh282.

[adanaamir]

Hi! @adhiamboperes I have opened a new PR to replace my previous PR #6287 , which was automatically closed after a force push. The updated PR is #6289 .

My proposed implementation adds a FAILURES counter to scripts/static_checks.sh to track whether any individual check fails during execution.

For example:

FAILURES=0

bash scripts/checkstyle_lint_check.sh || FAILURES=$((FAILURES+1))
bash scripts/ktlint_lint_check.sh || FAILURES=$((FAILURES+1))

Each check is executed normally, but if it exits with a non-zero status, the failure counter is incremented. This allows the script to continue running all remaining checks instead of stopping after the first failure.

At the end of the script, the value of FAILURES is evaluated:

if [ "$FAILURES" -gt 0 ]; then
    exit 1
else
    exit 0
fi

If one or more checks fail, the script reports the number of failed checks and exits with a non-zero status code. Otherwise, it prints All checks passed. and exits successfully.

This ensures that all checks run to completion while the overall script correctly reports failure when any individual check fails, matching the intended CI behavior.