OCPNODE-2096: Add ClusterImagePolicy to the list of valid config manifests#3894
Conversation
|
@QiWang19: This pull request references OCPNODE-2096 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
✅ Deploy Preview for hypershift-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
openshift-ci
Bot
added
area/ci-tooling
f746bce to
1d793a3
Compare
|
/test verify |
…fests Signed-off-by: Qi Wang <qiwan@redhat.com>
1d793a3 to
cffe1be
Compare
|
@csrwng PTAL. Do you think we have a chance to get this done by the 4.16 feature freeze? |
|
/test e2e-kubevirt-aws-ovn |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csrwng, QiWang19 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
@QiWang19: This pull request references OCPNODE-2096 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
@QiWang19: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-hypershift-container-v4.16.0-202404190512.p0.g942aee4.assembly.stream.el9 for distgit hypershift. |
Add ImagePolicy CRD to valid manifests as MCO bootstraps it. This is a namespaced CRD for image sigstore signature verification. Previously, we introduced the ClusterImagePolicy in PR openshift#3894 to support IBM ROKS deployments. This change aligns with our ongoing effort to ensure Hypershift remains consistent with OpenShift's functionality. we also allow hypershift users to configure imagepolicy for their namespaces, make sure hypershift provides the same set of features as OpenShift. Signed-off-by: Qi Wang <qiwan@redhat.com>
Add ImagePolicy CRD to valid manifests as MCO bootstraps it. This is a namespaced CRD for image sigstore signature verification. Previously, we introduced the ClusterImagePolicy in PR openshift#3894 to support IBM ROKS deployments. This change aligns with our ongoing effort to ensure Hypershift remains consistent with OpenShift's functionality. we also allow hypershift users to configure imagepolicy for their namespaces, make sure hypershift provides the same set of features as OpenShift. Signed-off-by: Qi Wang <qiwan@redhat.com>
5 participants
What this PR does / why we need it:
Add ClusterImagePolicy CRD to valid manifests as MCO bootstraps it. This cluster-wide CRD is for sigstore signature verification. IBM ROKS deployments will require this CRD to work through hypershift.
Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)format, where issue_number might be a GitHub issue, or a Jira story:Fixes # https://issues.redhat.com/browse/OCPNODE-2096
Checklist