OCPNODE-2552: Add ImagePolicy to the list of valid config manifests by QiWang19 · Pull Request #5094 · openshift/hypershift

QiWang19 · 2024-11-08T18:41:07Z

What this PR does / why we need it:
Add ImagePolicy CRD to valid manifests as MCO bootstraps it. This is a namespaced CRD for image sigstore signature verification. Previously, we introduced the ClusterImagePolicy in PR #3894 to support IBM ROKS deployments.
This change aligns with our ongoing effort to ensure Hypershift remains consistent with OpenShift's functionality.
we also allow hypershift users to configure imagepolicy for their namespaces, make sure hypershift provides the same set of features as OpenShift.
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes # https://issues.redhat.com//browse/OCPNODE-2552

Checklist

Subject and description added to both, commit and PR.
Relevant issues have been referenced.
This change includes docs.
This change includes unit tests.

openshift-ci-robot · 2024-11-08T18:41:51Z

@QiWang19: This pull request references OCPNODE-2552 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:
Add ImagePolicy CRD to valid manifests as MCO bootstraps it
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

Subject and description added to both, commit and PR.

Relevant issues have been referenced.

This change includes docs.

This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

netlify · 2024-11-08T18:42:16Z

✅ Deploy Preview for hypershift-docs ready!

Name	Link
🔨 Latest commit	`e2eb80c`
🔍 Latest deploy log	https://app.netlify.com/sites/hypershift-docs/deploys/673bb9a210349a00088f2ca1
😎 Deploy Preview	https://deploy-preview-5094--hypershift-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

openshift-ci-robot · 2024-11-08T20:51:46Z

@QiWang19: This pull request references OCPNODE-2552 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:
Add ImagePolicy CRD to valid manifests as MCO bootstraps it. This is a namespaced CRD for image sigstore signature verification.
We have added ClusterImagePoily before in PR #3894
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

Subject and description added to both, commit and PR.

Relevant issues have been referenced.

This change includes docs.

This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

bryan-cox · 2024-11-11T16:35:44Z

/retest

bryan-cox · 2024-11-11T16:36:32Z

Can you add the "why" in the commit description please? - See 5. in https://hypershift-docs.netlify.app/contribute/#prior-to-submitting-a-pull-request.

jparrill · 2024-11-18T08:33:20Z

Hey @QiWang19 thanks for the PR, could you please take a look to the Bryan's comment?

openshift-ci-robot · 2024-11-18T22:02:20Z

@QiWang19: This pull request references OCPNODE-2552 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:
Add ImagePolicy CRD to valid manifests as MCO bootstraps it. This is a namespaced CRD for image sigstore signature verification. Previously, we introduced the ClusterImagePolicy in PR #3894 to support IBM ROKS deployments.
This change aligns with our ongoing effort to ensure Hypershift remains consistent with OpenShift's functionality.
we also allow hypershift users to configure imagepolicy for their namespaces, make sure hypershift provides the same set of features as OpenShift.
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

Subject and description added to both, commit and PR.

Relevant issues have been referenced.

This change includes docs.

This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-11-18T22:02:42Z

@QiWang19: This pull request references OCPNODE-2552 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:
Add ImagePolicy CRD to valid manifests as MCO bootstraps it. This is a namespaced CRD for image sigstore signature verification. Previously, we introduced the ClusterImagePolicy in PR #3894 to support IBM ROKS deployments.
This change aligns with our ongoing effort to ensure Hypershift remains consistent with OpenShift's functionality.
we also allow hypershift users to configure imagepolicy for their namespaces, make sure hypershift provides the same set of features as OpenShift.
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes # https://issues.redhat.com//browse/OCPNODE-2552

Checklist

Subject and description added to both, commit and PR.

Relevant issues have been referenced.

This change includes docs.

This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

QiWang19 · 2024-11-19T02:02:48Z

/retest

QiWang19 · 2024-11-19T02:12:49Z

I updated the commit. PTAL @bryan-cox @jparrill

jparrill · 2024-11-19T09:27:49Z

/retest

jparrill

/lgtm

jparrill · 2024-11-19T09:32:22Z

/lgtm cancel

jparrill · 2024-11-19T09:34:31Z

@QiWang19 could you update the commit message with the OCPNODE id you have in the title and add some details you have in this PR's first message too as additional text?. Thanks!

Let me know for tagging.

Add ImagePolicy CRD to valid manifests as MCO bootstraps it. This is a namespaced CRD for image sigstore signature verification. Previously, we introduced the ClusterImagePolicy in PR openshift#3894 to support IBM ROKS deployments. This change aligns with our ongoing effort to ensure Hypershift remains consistent with OpenShift's functionality. we also allow hypershift users to configure imagepolicy for their namespaces, make sure hypershift provides the same set of features as OpenShift. Signed-off-by: Qi Wang <qiwan@redhat.com>

QiWang19 · 2024-11-19T15:24:07Z

@jparrill commit updated. PTAL

openshift-ci · 2024-11-19T15:27:22Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: QiWang19
Once this PR has been reviewed and has the lgtm label, please ask for approval from jparrill. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

enxebre · 2024-11-19T16:06:04Z

/hold

openshift-ci · 2024-11-19T18:19:30Z

@QiWang19: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aks	`ba581cd`	link	true	`/test e2e-aks`
ci/prow/e2e-kubevirt-aws-ovn-reduced	`ba581cd`	link	true	`/test e2e-kubevirt-aws-ovn-reduced`
ci/prow/e2e-aws	`ba581cd`	link	true	`/test e2e-aws`
ci/prow/images	`ba581cd`	link	true	`/test images`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

enxebre · 2024-11-27T16:59:39Z

Since ImageTagMirrorSet is cluster wide resource we'll come up with a semantic to expose it in the HC.

openshift-ci Bot added the do-not-merge/needs-area label Nov 8, 2024

QiWang19 changed the title ~~Add ImagePolicy to the list of valid config manifests~~ OCPNODE-2552: Add ImagePolicy to the list of valid config manifests Nov 8, 2024

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 8, 2024

openshift-ci Bot requested review from isco-rodriguez and sjenning November 8, 2024 18:41

QiWang19 force-pushed the imagepolicy branch from 00607bc to 3807e5c Compare November 8, 2024 19:02

QiWang19 force-pushed the imagepolicy branch from 3807e5c to e2eb80c Compare November 18, 2024 22:03

jparrill reviewed Nov 19, 2024

View reviewed changes

openshift-ci Bot assigned jparrill Nov 19, 2024

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2024

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2024

QiWang19 force-pushed the imagepolicy branch from e2eb80c to ba581cd Compare November 19, 2024 15:22

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2024

QiWang19 closed this Dec 10, 2024

Uh oh!

Conversation

QiWang19 commented Nov 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Nov 8, 2024 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify Bot commented Nov 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for hypershift-docs ready!

Uh oh!

openshift-ci-robot commented Nov 8, 2024 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bryan-cox commented Nov 11, 2024

Uh oh!

bryan-cox commented Nov 11, 2024

Uh oh!

jparrill commented Nov 18, 2024

Uh oh!

openshift-ci-robot commented Nov 18, 2024 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Nov 18, 2024 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

QiWang19 commented Nov 19, 2024

Uh oh!

QiWang19 commented Nov 19, 2024

Uh oh!

jparrill commented Nov 19, 2024

Uh oh!

jparrill left a comment

Choose a reason for hiding this comment

Uh oh!

jparrill commented Nov 19, 2024

Uh oh!

jparrill commented Nov 19, 2024

Uh oh!

QiWang19 commented Nov 19, 2024

Uh oh!

openshift-ci Bot commented Nov 19, 2024

Uh oh!

enxebre commented Nov 19, 2024

Uh oh!

openshift-ci Bot commented Nov 19, 2024

Uh oh!

enxebre commented Nov 27, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

QiWang19 commented Nov 8, 2024 •

edited

Loading

openshift-ci-robot commented Nov 8, 2024 •

edited by openshift-ci Bot

Loading

netlify Bot commented Nov 8, 2024 •

edited

Loading

openshift-ci-robot commented Nov 8, 2024 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Nov 18, 2024 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Nov 18, 2024 •

edited by openshift-ci Bot

Loading