NE-2727: Add image mirrors for external-dns-operator 1-3 components#468
Conversation
|
@grzpiotrowski: This pull request references NE-2727 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
📝 WalkthroughWalkthroughThis PR updates the ImageDigestMirrorSet configuration in Suggested reviewers
🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.tekton/images-mirror-set.yaml:
- Line 21: The quay.io RHEL 9 image entries in .tekton/images-mirror-set.yaml
(the image string
quay.io/redhat-user-workloads/external-dns-operator-tenant/ext-dns-optr-1-3-rhel-9/external-dns-operator-bundle-container-ext-dns-optr-1-3-rhel-9
and the other quay.io entries at lines 30-35) are not reachable; ensure those
images are published and publicly readable or that the mirror job has proper
pull credentials before applying this manifest. Update
.tekton/images-mirror-set.yaml to point to reachable image URIs (or add the
required pull secret/config for the mirroring job), verify with skopeo inspect
docker://<image> succeeds, and commit the corrected image references so the
mirroring config only contains accessible quay.io entries.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 0697deee-6119-4ccd-8135-10da381fafe8
📒 Files selected for processing (1)
.tekton/images-mirror-set.yaml
| mirrors: | ||
| - quay.io/redhat-user-workloads/external-dns-operator-tenant/ext-dns-optr-1-1-rhel-8/external-dns-operator-bundle-container-ext-dns-optr-1-1-rhel-8 | ||
| - quay.io/redhat-user-workloads/external-dns-operator-tenant/ext-dns-optr-1-2-rhel-8/external-dns-operator-bundle-container-ext-dns-optr-1-2-rhel-8 | ||
| - quay.io/redhat-user-workloads/external-dns-operator-tenant/ext-dns-optr-1-3-rhel-9/external-dns-operator-bundle-container-ext-dns-optr-1-3-rhel-9 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Verify that the new RHEL 9 mirror images exist and are accessible.
mirrors=(
"quay.io/redhat-user-workloads/external-dns-operator-tenant/ext-dns-optr-1-3-rhel-9/external-dns-operator-bundle-container-ext-dns-optr-1-3-rhel-9"
"quay.io/redhat-user-workloads/external-dns-operator-tenant/ext-dns-optr-1-3-rhel-9/external-dns-operator-container-ext-dns-optr-1-3-rhel-9"
"quay.io/redhat-user-workloads/external-dns-operator-tenant/ext-dns-optr-1-3-rhel-9/external-dns-container-ext-dns-optr-1-3-rhel-9"
)
echo "Verifying mirror image accessibility..."
all_ok=true
for mirror in "${mirrors[@]}"; do
echo "Checking: ${mirror}"
if skopeo inspect --no-tags "docker://${mirror}" &>/dev/null; then
echo "✓ ${mirror} is accessible"
else
echo "✗ ${mirror} is NOT accessible or does not exist"
all_ok=false
fi
done
if [ "$all_ok" = true ]; then
echo -e "\n✓ All mirror images are accessible"
else
echo -e "\n✗ Some mirror images are not accessible"
exit 1
fiRepository: openshift/external-dns-operator
Length of output: 1130
Ensure quay.io RHEL 9 mirror images are published and accessible
The referenced images in .tekton/images-mirror-set.yaml (lines 21 and 30-35) are not reachable: skopeo inspect --no-tags docker://... failed for all three quay.io references (not accessible or does not exist). Publish them (and ensure they’re publicly readable or that the mirroring job has the required pull credentials) before applying this configuration.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.tekton/images-mirror-set.yaml at line 21, The quay.io RHEL 9 image entries
in .tekton/images-mirror-set.yaml (the image string
quay.io/redhat-user-workloads/external-dns-operator-tenant/ext-dns-optr-1-3-rhel-9/external-dns-operator-bundle-container-ext-dns-optr-1-3-rhel-9
and the other quay.io entries at lines 30-35) are not reachable; ensure those
images are published and publicly readable or that the mirror job has proper
pull credentials before applying this manifest. Update
.tekton/images-mirror-set.yaml to point to reachable image URIs (or add the
required pull secret/config for the mirroring job), verify with skopeo inspect
docker://<image> succeeds, and commit the corrected image references so the
mirroring config only contains accessible quay.io entries.
|
@grzpiotrowski: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alebedev87 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adds image mirrors for external-dns-operator 1-3 components to support the v1.3.x stage bundles.
Similar to #422.