Skip to content

NE-2727: Add image mirrors for external-dns-operator 1-3 components#468

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
grzpiotrowski:NE-2727-1-3-digests-mirror
May 26, 2026
Merged

NE-2727: Add image mirrors for external-dns-operator 1-3 components#468
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
grzpiotrowski:NE-2727-1-3-digests-mirror

Conversation

@grzpiotrowski

Copy link
Copy Markdown
Contributor

Adds image mirrors for external-dns-operator 1-3 components to support the v1.3.x stage bundles.

Similar to #422.

@openshift-ci-robot

openshift-ci-robot commented May 26, 2026

Copy link
Copy Markdown

@grzpiotrowski: This pull request references NE-2727 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Adds image mirrors for external-dns-operator 1-3 components to support the v1.3.x stage bundles.

Similar to #422.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 26, 2026
@coderabbitai

coderabbitai Bot commented May 26, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

This PR updates the ImageDigestMirrorSet configuration in .tekton/images-mirror-set.yaml to add RHEL 9 stage registry mirror support. The changes introduce a new mirror tag for the external-dns-operator-bundle (ext-dns-optr-1-3-rhel-9) and create source mirror mappings for external-dns-rhel9-operator and external-dns-rhel9 components, both pointing to the ext-dns-optr-1-3-rhel-9 container image.

Suggested reviewers

  • alebedev87
  • Thealisyed
  • gcs278
🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adding image mirrors for external-dns-operator 1-3 components, which matches the file modifications documented in the summary.
Description check ✅ Passed The description is directly related to the changeset, explaining the purpose of adding image mirrors for external-dns-operator 1-3 components to support v1.3.x stage bundles.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only .tekton/images-mirror-set.yaml (YAML config), not test files. Custom check for Ginkgo test names is not applicable since no test files are involved.
Test Structure And Quality ✅ Passed PR only modifies .tekton/images-mirror-set.yaml (YAML configuration), not Ginkgo test code. Custom check for test structure is not applicable.
Microshift Test Compatibility ✅ Passed PR only modifies .tekton/images-mirror-set.yaml (image mirror configuration), not adding any Ginkgo e2e tests; custom check only applies when new tests are added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only modifies .tekton/images-mirror-set.yaml (YAML configuration file); no new Ginkgo e2e tests are added, so SNO test compatibility check does not apply.
Topology-Aware Scheduling Compatibility ✅ Passed PR only modifies .tekton/images-mirror-set.yaml (ImageDigestMirrorSet for image registry mirroring), not deployment manifests or controllers. No topology-aware scheduling constraints introduced.
Ote Binary Stdout Contract ✅ Passed PR only modifies .tekton/images-mirror-set.yaml (YAML configuration file); no Go source code changes, so OTE stdout contract check is not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR modifies only .tekton/images-mirror-set.yaml configuration file; no Ginkgo e2e tests added, so IPv6 check not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.tekton/images-mirror-set.yaml:
- Line 21: The quay.io RHEL 9 image entries in .tekton/images-mirror-set.yaml
(the image string
quay.io/redhat-user-workloads/external-dns-operator-tenant/ext-dns-optr-1-3-rhel-9/external-dns-operator-bundle-container-ext-dns-optr-1-3-rhel-9
and the other quay.io entries at lines 30-35) are not reachable; ensure those
images are published and publicly readable or that the mirror job has proper
pull credentials before applying this manifest. Update
.tekton/images-mirror-set.yaml to point to reachable image URIs (or add the
required pull secret/config for the mirroring job), verify with skopeo inspect
docker://<image> succeeds, and commit the corrected image references so the
mirroring config only contains accessible quay.io entries.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 0697deee-6119-4ccd-8135-10da381fafe8

📥 Commits

Reviewing files that changed from the base of the PR and between a4f0979 and bba1375.

📒 Files selected for processing (1)
  • .tekton/images-mirror-set.yaml

mirrors:
- quay.io/redhat-user-workloads/external-dns-operator-tenant/ext-dns-optr-1-1-rhel-8/external-dns-operator-bundle-container-ext-dns-optr-1-1-rhel-8
- quay.io/redhat-user-workloads/external-dns-operator-tenant/ext-dns-optr-1-2-rhel-8/external-dns-operator-bundle-container-ext-dns-optr-1-2-rhel-8
- quay.io/redhat-user-workloads/external-dns-operator-tenant/ext-dns-optr-1-3-rhel-9/external-dns-operator-bundle-container-ext-dns-optr-1-3-rhel-9

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Verify that the new RHEL 9 mirror images exist and are accessible.

mirrors=(
  "quay.io/redhat-user-workloads/external-dns-operator-tenant/ext-dns-optr-1-3-rhel-9/external-dns-operator-bundle-container-ext-dns-optr-1-3-rhel-9"
  "quay.io/redhat-user-workloads/external-dns-operator-tenant/ext-dns-optr-1-3-rhel-9/external-dns-operator-container-ext-dns-optr-1-3-rhel-9"
  "quay.io/redhat-user-workloads/external-dns-operator-tenant/ext-dns-optr-1-3-rhel-9/external-dns-container-ext-dns-optr-1-3-rhel-9"
)

echo "Verifying mirror image accessibility..."
all_ok=true

for mirror in "${mirrors[@]}"; do
  echo "Checking: ${mirror}"
  if skopeo inspect --no-tags "docker://${mirror}" &>/dev/null; then
    echo "${mirror} is accessible"
  else
    echo "${mirror} is NOT accessible or does not exist"
    all_ok=false
  fi
done

if [ "$all_ok" = true ]; then
  echo -e "\n✓ All mirror images are accessible"
else
  echo -e "\n✗ Some mirror images are not accessible"
  exit 1
fi

Repository: openshift/external-dns-operator

Length of output: 1130


Ensure quay.io RHEL 9 mirror images are published and accessible
The referenced images in .tekton/images-mirror-set.yaml (lines 21 and 30-35) are not reachable: skopeo inspect --no-tags docker://... failed for all three quay.io references (not accessible or does not exist). Publish them (and ensure they’re publicly readable or that the mirroring job has the required pull credentials) before applying this configuration.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.tekton/images-mirror-set.yaml at line 21, The quay.io RHEL 9 image entries
in .tekton/images-mirror-set.yaml (the image string
quay.io/redhat-user-workloads/external-dns-operator-tenant/ext-dns-optr-1-3-rhel-9/external-dns-operator-bundle-container-ext-dns-optr-1-3-rhel-9
and the other quay.io entries at lines 30-35) are not reachable; ensure those
images are published and publicly readable or that the mirror job has proper
pull credentials before applying this manifest. Update
.tekton/images-mirror-set.yaml to point to reachable image URIs (or add the
required pull secret/config for the mirroring job), verify with skopeo inspect
docker://<image> succeeds, and commit the corrected image references so the
mirroring config only contains accessible quay.io entries.

@openshift-ci

openshift-ci Bot commented May 26, 2026

Copy link
Copy Markdown
Contributor

@grzpiotrowski: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@alebedev87

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2026
@openshift-ci

openshift-ci Bot commented May 26, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit baa1442 into openshift:main May 26, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants