Skip to content

NE-2727: Update FBC Catalogs with stage v1.3.5 bundle#467

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
grzpiotrowski:NE-2727-stage-fbc
May 26, 2026
Merged

NE-2727: Update FBC Catalogs with stage v1.3.5 bundle#467
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
grzpiotrowski:NE-2727-stage-fbc

Conversation

@grzpiotrowski

Copy link
Copy Markdown
Contributor
  • Add the v1.3.5 stage bundle to all FBC catalog templates (v4.12-v4.22) in channels stable-v1 and stable-v1.3.
  • Regenerate the catalogs with OCP_VERSION=4.x make generate-catalog

@openshift-ci-robot

openshift-ci-robot commented May 25, 2026

Copy link
Copy Markdown

@grzpiotrowski: This pull request references NE-2727 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

  • Add the v1.3.5 stage bundle to all FBC catalog templates (v4.12-v4.22) in channels stable-v1 and stable-v1.3.
  • Regenerate the catalogs with OCP_VERSION=4.x make generate-catalog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 25, 2026
@coderabbitai

coderabbitai Bot commented May 25, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@grzpiotrowski, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 30 minutes and 52 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 9d6d96c4-a605-4864-9984-20c2e7ba3be8

📥 Commits

Reviewing files that changed from the base of the PR and between c3f794b and 246b85d.

📒 Files selected for processing (22)
  • catalog/v4.12/catalog-template.yaml
  • catalog/v4.12/catalog.yaml
  • catalog/v4.13/catalog-template.yaml
  • catalog/v4.13/catalog.yaml
  • catalog/v4.14/catalog-template.yaml
  • catalog/v4.14/catalog.yaml
  • catalog/v4.15/catalog-template.yaml
  • catalog/v4.15/catalog.yaml
  • catalog/v4.16/catalog-template.yaml
  • catalog/v4.16/catalog.yaml
  • catalog/v4.17/catalog-template.yaml
  • catalog/v4.17/catalog.yaml
  • catalog/v4.18/catalog-template.yaml
  • catalog/v4.18/catalog.yaml
  • catalog/v4.19/catalog-template.yaml
  • catalog/v4.19/catalog.yaml
  • catalog/v4.20/catalog-template.yaml
  • catalog/v4.20/catalog.yaml
  • catalog/v4.21/catalog-template.yaml
  • catalog/v4.21/catalog.yaml
  • catalog/v4.22/catalog-template.yaml
  • catalog/v4.22/catalog.yaml
📝 Walkthrough

Walkthrough

This PR registers external-dns-operator v1.3.5 across catalogs v4.12–v4.22: it adds v1.3.5 to stable-v1 and stable-v1.3 channel entries (replaces: v1.3.4, skipRange: <1.3.5) in templates and rendered catalog YAMLs, and adds/updates the corresponding olm.bundle blocks with new stage-registry bundle image digests, embedded bundle payloads, and relatedImages.

Possibly related PRs

Suggested reviewers

  • davidesalerno
  • gcs278
  • melvinjoseph86
🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: updating FBC catalogs with the stage v1.3.5 bundle, which matches the substantial additions across all catalog files.
Description check ✅ Passed The description directly relates to the changeset by explaining what was added (v1.3.5 stage bundle to catalog templates) and the regeneration process used, matching the catalog updates shown in the raw summary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only YAML catalog configuration files, not Ginkgo test files. The check for stable test names does not apply to YAML catalogs.
Test Structure And Quality ✅ Passed PR only modifies YAML catalog files for operator versioning. No Ginkgo test code was added or modified, making this check not applicable.
Microshift Test Compatibility ✅ Passed No Ginkgo e2e tests are added in this PR. Changes are limited to OLM catalog YAML configuration files updating external-dns-operator version from v1.3.4 to v1.3.5.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR modifies only YAML catalog configuration files (OLM bundle metadata), not Ginkgo e2e tests. The SNO compatibility check is not applicable as no test code was added.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only OLM catalog metadata files with no deployment manifests, operator code, controllers, or scheduling constraints added/modified.
Ote Binary Stdout Contract ✅ Passed PR modifies only YAML catalog configuration files (catalog/v4.x/*); no Go source code, test files, or process-level code is modified, so OTE Binary Stdout Contract check is not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR modifies only YAML OLM catalog files (v4.12-v4.22 catalog-template.yaml and catalog.yaml) with no Ginkgo e2e tests added, so IPv6/disconnected network compatibility check is not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from davidesalerno and gcs278 May 25, 2026 21:16

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@catalog/v4.19/catalog.yaml`:
- Around line 5269-5278: The kube-rbac-proxy image in catalog.yaml is using the
production registry (registry.redhat.io) while the rest of this v1.3.5 stage
bundle uses registry.stage.redhat.io; update the image reference for the
kube-rbac-proxy entry (the image paired with name: kube-rbac-proxy) to the
corresponding registry.stage.redhat.io location (or replace it with the
stage-appropriate sha256 digest) so all images in this stage bundle consistently
reference the stage registry, and verify the change against the other
external-dns-related image entries (external-dns-operator,
external-dns-rhel9-operator, external_dns) to ensure uniform registry usage.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: a146fdec-d205-460e-984e-0db075f35ade

📥 Commits

Reviewing files that changed from the base of the PR and between a4f0979 and bd0119d.

📒 Files selected for processing (23)
  • catalog/v4.12/catalog-template.yaml
  • catalog/v4.12/catalog.yaml
  • catalog/v4.13/catalog-template.yaml
  • catalog/v4.13/catalog.yaml
  • catalog/v4.14/catalog-template.yaml
  • catalog/v4.14/catalog.yaml
  • catalog/v4.15/catalog-template.yaml
  • catalog/v4.15/catalog.yaml
  • catalog/v4.16/catalog-template.yaml
  • catalog/v4.16/catalog.yaml
  • catalog/v4.17/catalog-template.yaml
  • catalog/v4.17/catalog.yaml
  • catalog/v4.18/catalog-template.yaml
  • catalog/v4.18/catalog.yaml
  • catalog/v4.19/catalog-template.yaml
  • catalog/v4.19/catalog.yaml
  • catalog/v4.20/catalog-template.yaml
  • catalog/v4.20/catalog.yaml
  • catalog/v4.21/catalog-template.yaml
  • catalog/v4.21/catalog.yaml
  • catalog/v4.22/catalog-template.yaml
  • catalog/v4.22/catalog.yaml
  • catalog/v4.42/catalog.yaml

Comment thread catalog/v4.19/catalog.yaml
@grzpiotrowski

Copy link
Copy Markdown
Contributor Author

/hold

Needs #468 first. Bundle sha will change after .tekton change.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2026
@melvinjoseph86

Copy link
Copy Markdown
Contributor

/retest-required

@grzpiotrowski

Copy link
Copy Markdown
Contributor Author

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2026
Comment thread catalog/v4.42/catalog.yaml Outdated
@alebedev87

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2026
@openshift-ci

openshift-ci Bot commented May 26, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2026
@grzpiotrowski

Copy link
Copy Markdown
Contributor Author

/test e2e-azure-operator

@openshift-ci

openshift-ci Bot commented May 26, 2026

Copy link
Copy Markdown
Contributor

@grzpiotrowski: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit f3de661 into openshift:main May 26, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants