NE-2727: Update FBC Catalogs with stage v1.3.5 bundle#467
Conversation
|
@grzpiotrowski: This pull request references NE-2727 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Warning Review limit reached
More reviews will be available in 30 minutes and 52 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (22)
📝 WalkthroughWalkthroughThis PR registers external-dns-operator v1.3.5 across catalogs v4.12–v4.22: it adds v1.3.5 to stable-v1 and stable-v1.3 channel entries (replaces: v1.3.4, skipRange: <1.3.5) in templates and rendered catalog YAMLs, and adds/updates the corresponding olm.bundle blocks with new stage-registry bundle image digests, embedded bundle payloads, and relatedImages. Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@catalog/v4.19/catalog.yaml`:
- Around line 5269-5278: The kube-rbac-proxy image in catalog.yaml is using the
production registry (registry.redhat.io) while the rest of this v1.3.5 stage
bundle uses registry.stage.redhat.io; update the image reference for the
kube-rbac-proxy entry (the image paired with name: kube-rbac-proxy) to the
corresponding registry.stage.redhat.io location (or replace it with the
stage-appropriate sha256 digest) so all images in this stage bundle consistently
reference the stage registry, and verify the change against the other
external-dns-related image entries (external-dns-operator,
external-dns-rhel9-operator, external_dns) to ensure uniform registry usage.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: a146fdec-d205-460e-984e-0db075f35ade
📒 Files selected for processing (23)
catalog/v4.12/catalog-template.yamlcatalog/v4.12/catalog.yamlcatalog/v4.13/catalog-template.yamlcatalog/v4.13/catalog.yamlcatalog/v4.14/catalog-template.yamlcatalog/v4.14/catalog.yamlcatalog/v4.15/catalog-template.yamlcatalog/v4.15/catalog.yamlcatalog/v4.16/catalog-template.yamlcatalog/v4.16/catalog.yamlcatalog/v4.17/catalog-template.yamlcatalog/v4.17/catalog.yamlcatalog/v4.18/catalog-template.yamlcatalog/v4.18/catalog.yamlcatalog/v4.19/catalog-template.yamlcatalog/v4.19/catalog.yamlcatalog/v4.20/catalog-template.yamlcatalog/v4.20/catalog.yamlcatalog/v4.21/catalog-template.yamlcatalog/v4.21/catalog.yamlcatalog/v4.22/catalog-template.yamlcatalog/v4.22/catalog.yamlcatalog/v4.42/catalog.yaml
|
/hold Needs #468 first. Bundle sha will change after |
|
/retest-required |
bd0119d to
c3f794b
Compare
|
/hold cancel |
c3f794b to
246b85d
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alebedev87 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-azure-operator |
|
@grzpiotrowski: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
stable-v1andstable-v1.3.OCP_VERSION=4.x make generate-catalog