Skip to content

7904060: Enable profiler classes to be reused outside of JMH#162

Open
galderz wants to merge 1 commit into
openjdk:masterfrom
galderz:topic.fibula-help.040
Open

7904060: Enable profiler classes to be reused outside of JMH#162
galderz wants to merge 1 commit into
openjdk:masterfrom
galderz:topic.fibula-help.040

Conversation

@galderz

@galderz galderz commented Jul 8, 2025

Copy link
Copy Markdown
Contributor

This is the fourth in a series of PRs that I will be sending over the next few days, which make extending JMH to benchmark Java code running as GraalVM native images more easily. The codename for this extension is Fibula. It can still work without this PRs but without them the extension has to duplicate code that exists in JMH, which is not desirable.

This PR makes ProfilerOptionFormatter and ProfilerUtils classes public so that they can be reused by external profilers. An example of this usage can be seen in this perf dwarf profiler used for native image JMH benchmarks.

Here is the PR list for reference:

  1. Make OutputFormatAdapter public
  2. Enable BenchmarkParams construction to be overriden
  3. Enable alternative Runner instantiation and Main reuse
  4. Enable profiler classes to be reused outside of JMH
  5. Enable JMH integration tests to be executed against other impls

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Error

 ⚠️ Pull request body is missing required line: - [x] I confirm that I make this contribution in accordance with the [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).

Issue

  • CODETOOLS-7904060: Enable profiler classes to be reused outside of JMH (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmh.git pull/162/head:pull/162
$ git checkout pull/162

Update a local copy of the PR:
$ git checkout pull/162
$ git pull https://git.openjdk.org/jmh.git pull/162/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 162

View PR using the GUI difftool:
$ git pr show -t 162

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmh/pull/162.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jul 8, 2025

Copy link
Copy Markdown

👋 Welcome back galder! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jul 8, 2025

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Jul 8, 2025
@mlbridge

mlbridge Bot commented Jul 8, 2025

Copy link
Copy Markdown

Webrevs

@bridgekeeper

bridgekeeper Bot commented Aug 5, 2025

Copy link
Copy Markdown

@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@galderz

galderz commented Aug 6, 2025

Copy link
Copy Markdown
Contributor Author

/touch

@openjdk

openjdk Bot commented Aug 6, 2025

Copy link
Copy Markdown

@galderz The pull request is being re-evaluated and the inactivity timeout has been reset.

@bridgekeeper

bridgekeeper Bot commented Sep 3, 2025

Copy link
Copy Markdown

@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@galderz

galderz commented Sep 4, 2025

Copy link
Copy Markdown
Contributor Author

/touch

@openjdk

openjdk Bot commented Sep 4, 2025

Copy link
Copy Markdown

@galderz The pull request is being re-evaluated and the inactivity timeout has been reset.

@bridgekeeper

bridgekeeper Bot commented Oct 2, 2025

Copy link
Copy Markdown

@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@galderz

galderz commented Oct 9, 2025

Copy link
Copy Markdown
Contributor Author

/touch

@openjdk

openjdk Bot commented Oct 9, 2025

Copy link
Copy Markdown

@galderz The pull request is being re-evaluated and the inactivity timeout has been reset.

@bridgekeeper

bridgekeeper Bot commented Nov 6, 2025

Copy link
Copy Markdown

@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@galderz

galderz commented Nov 6, 2025

Copy link
Copy Markdown
Contributor Author

/touch

@openjdk

openjdk Bot commented Nov 6, 2025

Copy link
Copy Markdown

@galderz The pull request is being re-evaluated and the inactivity timeout has been reset.

@bridgekeeper

bridgekeeper Bot commented Dec 4, 2025

Copy link
Copy Markdown

@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@galderz

galderz commented Dec 11, 2025

Copy link
Copy Markdown
Contributor Author

/touch

@openjdk

openjdk Bot commented Dec 11, 2025

Copy link
Copy Markdown

@galderz The pull request is being re-evaluated and the inactivity timeout has been reset.

@bridgekeeper

bridgekeeper Bot commented Jan 8, 2026

Copy link
Copy Markdown

@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@galderz

galderz commented Jan 12, 2026

Copy link
Copy Markdown
Contributor Author

/touch

@openjdk

openjdk Bot commented Jan 12, 2026

Copy link
Copy Markdown

@galderz The pull request is being re-evaluated and the inactivity timeout has been reset.

@bridgekeeper

bridgekeeper Bot commented Feb 9, 2026

Copy link
Copy Markdown

@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@galderz

galderz commented Feb 12, 2026

Copy link
Copy Markdown
Contributor Author

/touch

@openjdk

openjdk Bot commented Feb 12, 2026

Copy link
Copy Markdown

@galderz The pull request is being re-evaluated and the inactivity timeout has been reset.

@bridgekeeper

bridgekeeper Bot commented Mar 12, 2026

Copy link
Copy Markdown

@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@galderz

galderz commented Mar 17, 2026

Copy link
Copy Markdown
Contributor Author

/touch

@openjdk

openjdk Bot commented Mar 17, 2026

Copy link
Copy Markdown

@galderz The pull request is being re-evaluated and the inactivity timeout has been reset.

@bridgekeeper

bridgekeeper Bot commented Apr 14, 2026

Copy link
Copy Markdown

@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@galderz

galderz commented Apr 14, 2026

Copy link
Copy Markdown
Contributor Author

/touch

@openjdk

openjdk Bot commented Apr 14, 2026

Copy link
Copy Markdown

@galderz The pull request is being re-evaluated and the inactivity timeout has been reset.

@openjdk openjdk Bot removed the rfr Pull request is ready for review label Apr 14, 2026
@bridgekeeper

bridgekeeper Bot commented May 13, 2026

Copy link
Copy Markdown

@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@galderz

galderz commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

/touch

@openjdk

openjdk Bot commented May 19, 2026

Copy link
Copy Markdown

@galderz The pull request is being re-evaluated and the inactivity timeout has been reset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant