7904058: Enable BenchmarkParams construction to be overriden#160
7904058: Enable BenchmarkParams construction to be overriden#160galderz wants to merge 1 commit into
Conversation
* It enables Fibula to construct BenchmarkParams instances with some custom field values that are required for native mode. * Some reflection might still needed to adjust fields. E.g with PGO where the executable to instrument, and the optimized executable are located in different paths.
|
👋 Welcome back galder! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/touch |
|
@galderz The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/touch |
|
@galderz The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
/touch |
|
@galderz The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/touch |
|
@galderz The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/touch |
|
@galderz The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/touch |
|
@galderz The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/touch |
|
@galderz The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/touch |
|
@galderz The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/touch |
|
@galderz The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/touch |
|
@galderz The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/touch |
|
@galderz The pull request is being re-evaluated and the inactivity timeout has been reset. |
1 participant
This is the second in a series of PRs that I will be sending over the next few days, which make extending JMH to benchmark Java code running as GraalVM native images more easily. The codename for this extension is Fibula. It can still work without this PRs but without them the extension has to duplicate code that exists in JMH, which is not desirable.
This PR enables
BenchmarkParamsconstruction to be overriden, in order to easily support JMH use case for benchmarking native images. The JIRA contains a detailed explanation. Having this PR in simplifies construction ofBenchmarkParamsinstance. The changes galderz/fibula@8fd8cf3#diff-601b6d98eff18db8a804efb415d515c3d397d42b9c982713b72c37bea2ebbf18 demonstrate the simplification enabled by the changes here.Here is the PR list for reference:
Progress
Error
- [x] I confirm that I make this contribution in accordance with the [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jmh.git pull/160/head:pull/160$ git checkout pull/160Update a local copy of the PR:
$ git checkout pull/160$ git pull https://git.openjdk.org/jmh.git pull/160/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 160View PR using the GUI difftool:
$ git pr show -t 160Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmh/pull/160.diff
Using Webrev
Link to Webrev Comment