Sqlite3 semconv optin tests#4836
Open
henry3260 wants to merge 2 commits into
Open
Conversation
…est coverage Cover database,http and database/dup,http/dup opt-in modes, verifying stable-only and dual-emission span attributes, mirroring the pattern from open-telemetry#4810. sqlite3 captures no connection attributes, so only db.system.name/db.query.text (and their legacy counterparts in dup mode) are asserted.
Contributor
|
@henry3260 Hey Henry, we appreciate PRs but please slow down a bit, you have already 8 PRs open :) |
Contributor
Author
Got it! Thanks for the heads-up. I'll hold off on opening new PRs for now until the current ones are reviewed. Take your time! :) I know reviewing takes a lot of time and effort. |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds two tests mirroring the merged mysql (#4810) / mysqlclient (#4834)
pattern, exercised against a real in-memory SQLite connection:
test_semconv_stable(database,http): asserts only stable attributes areemitted (
db.system.name,db.query.text) and legacy ones (db.system,db.statement) are absenttest_semconv_dup(database/dup,http/dup): asserts both legacy and stableattributes are emitted with correct values
Unlike the other dbapi-based instrumentations, sqlite3 captures no connection
attributes (
_CONNECTION_ATTRIBUTESis empty), so the tests also verify thatdb.name/db.namespace,db.user,net.peer.*andserver.*are absent inboth modes.
Type of change
How Has This Been Tested?
tox -e py312-test-instrumentation-sqlite3— 10 passed (8 existing + 2 new)tox -e lint-instrumentation-sqlite3— pylint 10.00/10pre-commit run ruff/ruff-format— cleanDoes This PR Require a Core Repo Change?
Checklist: