opentelemetry-instrumentation-sqlite3: add semconv stability opt-in test coverage#4848
Closed
SurbhiD404 wants to merge 4 commits into
Closed
opentelemetry-instrumentation-sqlite3: add semconv stability opt-in test coverage#4848SurbhiD404 wants to merge 4 commits into
SurbhiD404 wants to merge 4 commits into
Conversation
herin049
approved these changes
Jul 22, 2026
| ) | ||
|
|
||
| def test_new_semconv(self): | ||
| with mock.patch.dict( |
Contributor
|
FYI this overlaps with #4836, which covers the same semconv stability opt-in tests for sqlite3. |
Contributor
Author
|
Just wanted to flag that this overlaps with #4836, which also adds sqlite3 semconv stability test coverage and was opened a few days earlier. I wanted to make sure the overlap was visible before this goes further. I'm happy to adjust this PR, incorporate any additional feedback, or otherwise follow whichever direction you think is best for consolidating the work. |
Contributor
|
Closed as dup and also for the bot answer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4847
This PR adds instrumentation-level semconv stability opt-in test coverage for
opentelemetry-instrumentation-sqlite3.The sqlite3 instrumentation already declares semantic convention migration support (
_semconv_status = "migration") and routes through the shared DBAPI wrapper's stability-mode logic, but its instrumentation-specific test suite did not verify the supportedOTEL_SEMCONV_STABILITY_OPT_INmodes.This change adds a
TestSQLite3SemconvStabilitytest class covering the three supported semantic convention modes:databasedatabase/dupThe tests verify the expected span attributes (
DB_SYSTEM/DB_STATEMENTvs.DB_SYSTEM_NAME/DB_QUERY_TEXT) and the emittedschema_urlfor each mode, following the testing pattern already used by other migration-enabled instrumentations, including Cassandra (#4747), pymemcache (#4739), pymongo (#4772), and MySQL (#4810).No production code changes are included.
Type of change
How Has This Been Tested?
Verified locally against the current
mainbranch:opentelemetry-instrumentation-sqlite3test suite passes (11/11 tests)pre-commit(ruff, ruff-format) passesReproduce with:
Does This PR Require a Core Repo Change?
Checklist: