Skip to content

Add role to AgentConfigFile #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dmitryax wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −2
Open

Add role to AgentConfigFile #350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions proto/opamp/v1/opamp.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1045,13 +1045,18 @@ message AgentConfigMap {
}

message AgentConfigFile {
// Config file or section body. The content, format and encoding depends on the Agent
// type. The content_type field may optionally describe the MIME type of the body.
// Config file, section, or supplementary content body. The content, format and
// encoding depends on the Agent type. The content_type field may optionally
// describe the MIME type of the body.
bytes body = 1;

// Optional MIME Content-Type that describes what's in the body field, for
// example "text/yaml".
string content_type = 2;

// Optional role of the content in the body field. The values and their semantics
// are Agent type-specific.
string role = 3;
}

/////////////////////////////////////////////////////////////////////////////////////
Expand Down
6 changes: 6 additions & 0 deletions specification.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2626,6 +2626,7 @@ following structure:
message AgentConfigFile {
bytes body = 1;
string content_type = 2;
string role = 3;
}
```

Expand All @@ -2639,6 +2640,11 @@ reported in the Effective Configuration in the Agent's status report may be used
for example by the Server to visualize the reported configuration nicely in a
UI.

role is an optional field that describes the role of the content. The values and
their semantics are Agent type-specific. For example, an Agent type may use this
field to distinguish top-level configuration from supplementary content such as
certificates or other artifacts referenced by configuration.

#### Security Considerations

Remote Configuration is a potentially dangerous functionality that may be
Expand Down