Add role to AgentConfigFile#350
Conversation
43411ad to
ba0a5fc
Compare
ba0a5fc to
33eafed
Compare
33eafed to
ec43a68
Compare
|
This looks good to me. |
|
@dmitryax do you want to make this ready for review? |
There was a problem hiding this comment.
Pull request overview
Adds an optional role field to AgentConfigFile to let agent implementations distinguish top-level configuration from other config-related/supplementary content (per #184).
Changes:
- Extended
AgentConfigFilein the protobuf schema withstring role = 3. - Documented the new field and its agent-type-specific semantics in the specification.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
specification.md |
Documents the new role field and its intended usage for remote/effective configuration files. |
proto/opamp.proto |
Adds role to the wire schema for AgentConfigFile and includes field-level documentation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ec43a68 to
a40c420
Compare
a40c420 to
73daee4
Compare
|
@tigrannajaryan sorry, I missed this PR. Marked as ready for review |
|
I will keep it open for a bit in case @andykellr or @evan-bradley want to review. |
|
The description is a bit vague, I did not get the exact point.
The name itself suggests some fixed purpose. Why not then just |
Adds optional
roletoAgentConfigFileso agent-specific implementations can distinguish top-level configuration from supplementary content.Fixes #184