Skip to content

Add role to AgentConfigFile#350

Open
dmitryax wants to merge 1 commit into
open-telemetry:mainfrom
dmitryax:add-agent-config-file-role
Open

Add role to AgentConfigFile#350
dmitryax wants to merge 1 commit into
open-telemetry:mainfrom
dmitryax:add-agent-config-file-role

Conversation

@dmitryax

@dmitryax dmitryax commented Jun 3, 2026

Copy link
Copy Markdown
Member

Adds optional role to AgentConfigFile so agent-specific implementations can distinguish top-level configuration from supplementary content.

Fixes #184

@dmitryax dmitryax force-pushed the add-agent-config-file-role branch from 43411ad to ba0a5fc Compare June 3, 2026 00:08
@dmitryax dmitryax changed the title Add file_role to AgentConfigFile Add content_role to AgentConfigFile Jun 3, 2026
@dmitryax dmitryax force-pushed the add-agent-config-file-role branch from ba0a5fc to 33eafed Compare June 3, 2026 00:25
@dmitryax dmitryax changed the title Add content_role to AgentConfigFile Add role to AgentConfigFile Jun 3, 2026
@dmitryax dmitryax force-pushed the add-agent-config-file-role branch from 33eafed to ec43a68 Compare June 3, 2026 03:45
@tigrannajaryan

Copy link
Copy Markdown
Member

This looks good to me.

@tigrannajaryan

Copy link
Copy Markdown
Member

@dmitryax do you want to make this ready for review?

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an optional role field to AgentConfigFile to let agent implementations distinguish top-level configuration from other config-related/supplementary content (per #184).

Changes:

  • Extended AgentConfigFile in the protobuf schema with string role = 3.
  • Documented the new field and its agent-type-specific semantics in the specification.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
specification.md Documents the new role field and its intended usage for remote/effective configuration files.
proto/opamp.proto Adds role to the wire schema for AgentConfigFile and includes field-level documentation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread proto/opamp.proto Outdated
Comment thread specification.md Outdated
@dmitryax dmitryax marked this pull request as ready for review June 25, 2026 20:06
@dmitryax dmitryax requested a review from a team as a code owner June 25, 2026 20:06
@dmitryax dmitryax force-pushed the add-agent-config-file-role branch from ec43a68 to a40c420 Compare June 25, 2026 20:16
@dmitryax dmitryax force-pushed the add-agent-config-file-role branch from a40c420 to 73daee4 Compare June 25, 2026 20:24
@dmitryax

Copy link
Copy Markdown
Member Author

@tigrannajaryan sorry, I missed this PR. Marked as ready for review

@tigrannajaryan

Copy link
Copy Markdown
Member

I will keep it open for a bit in case @andykellr or @evan-bradley want to review.

@RassK

RassK commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

The description is a bit vague, I did not get the exact point.
The first part is very generic:

The values and their semantics are Agent type-specific.

The name itself suggests some fixed purpose.

Why not then just metadata instead of a role, so it's much more compatible with wider needs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a field for non-config files to AgentRemoteConfig

4 participants