Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/ISSUE_TEMPLATE/stabilization-review.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ Delete the guidance comments after filling in the form.
| … | … | … | … |
-->
* **Public docs / getting-started sample:** <link>
* **Specification deviations:** <link to any approved GC exception and user-facing documentation, or `None`>
* **CHANGELOG draft:** <link>

<!--
Expand All @@ -51,7 +52,7 @@ It is ideal to perform a stabilization review before a release candidate is gene
## 5. Self-checklist

- [ ] I understand the [TC review process](../../guides/contributor/processes.md#tc-stability-review) and commit to being responsive to any requests for assistance and to issues opened during the review.
- [ ] All **MUST / MUST NOT** requirements implemented
- [ ] All **MUST**, **MUST NOT**, and **REQUIRED** specification requirements are implemented, except for any [specification deviations](../../guides/contributor/processes.md#specification-deviations) approved by the GC and documented in the component repository
- [ ] [Spec compliance matrix](https://github.com/open-telemetry/opentelemetry-specification/blob/main/spec-compliance-matrix.md) populated and up-to-date
- [ ] Docs & examples updated
- [ ] Test suites passing
Expand Down
2 changes: 1 addition & 1 deletion assets.md
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ CNCF are the owners of the group, so certain requests (e.g. adding/removing orga
* CNCF Service Desk
* https://github.com/cncf/communitygroups/issues

Link: https://community.cncf.io/opentelemetry/
Link: https://community.cncf.io/opentelemetry-live/

- Owners: CNCF
- Lead Organizers (i.e. admins):
Expand Down
20 changes: 20 additions & 0 deletions guides/contributor/processes.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ help, and how changes are merged and released.
- [GitHub workflow](#github-workflow)
- [Open a Pull Request](#open-a-pull-request)
- [Code Review](#code-review)
- [TC Stability Review](#tc-stability-review)
- [Specification deviations](#specification-deviations)
- [Code attribution and licensing](#code-attribution-and-licensing)
- [Copyright Notices](#copyright-notices)
- [Specification Changes](#specification-changes)
Expand Down Expand Up @@ -205,6 +207,24 @@ responsive to any requests for assistance and to issues opened. In other words,
a TC stability review is a dialogue requiring engagement from both the TC and
language SDK maintainers.

### Specification deviations

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if this is the right place to document this requirement. There is no requirement that a language implementation must request a TC review itself. And it feels a bit odd that TC is the one reviewing, but GC is the one approving the exemptions if any.


Stable OpenTelemetry components are expected to satisfy all **MUST**,
**MUST NOT**, and **REQUIRED** specification requirements. If maintainers believe
a required part of the specification should not be implemented for a component,
the exception is a product decision owned by the
[Governance Committee](../../governance-charter.md), not only a
component-specific decision.

Specification exceptions are not recommended, but may be granted by the
Governance Committee after review, discussion, and vote. This review and
discussion may include recommendations from the Technical Committee,
maintainers, or other SIGs.

If an exception is granted, the component repository must document the deviation
and make it clear to users. The Governance Committee may remove an exception if
circumstances change, using similar review rigor.

## Code attribution and licensing

[License information](../../README.md#license) should be included in all source files where applicable.
Expand Down