Skip to content

Use default CI matrix #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mxgrey merged 4 commits into from
Jun 16, 2026
Merged

Use default CI matrix #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
42a02e1
Use default CI matrix
luca-della-vedova Jun 9, 2026
576e1e0
Merge branch 'main' into luca/default_ci
mxgrey Jun 16, 2026
048db97
Make all style tests optional
mxgrey Jun 16, 2026
67ee532
Migrate to newer testing config for setup.py
mxgrey Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,4 @@ jobs:
rmf_visualization_obstacles
rmf_visualization_rviz2_plugins
rmf_visualization_schedule
dist-matrix: '[{"ros_distribution": "rolling", "ubuntu_distribution": "noble"}]'

22 changes: 0 additions & 22 deletions .github/workflows/style.yaml
View file
Open in desktop

This file was deleted.

4 changes: 3 additions & 1 deletion rmf_visualization_building_systems/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@
maintainer_email='yadunund@openrobotics.org',
description='A visualizer for doors and lifts',
license='Apache License, Version 2.0',
tests_require=['pytest'],
extras_require={
'test': ['pytest'],
},
entry_points={
'console_scripts': [
'rmf_visualization_building_systems = \
Expand Down
3 changes: 2 additions & 1 deletion rmf_visualization_fleet_states/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ rclcpp_components_register_node(fleetstates_visualizer
EXECUTABLE fleetstates_visualizer_node)

#===============================================================================
if(BUILD_TESTING)
option(STYLE_TEST "Run uncrustify to evaluate the code style")
if(BUILD_TESTING AND STYLE_TEST)
find_package(ament_cmake_uncrustify REQUIRED)
find_package(rmf_utils REQUIRED)
find_file(uncrustify_config_file
Expand Down
3 changes: 2 additions & 1 deletion rmf_visualization_floorplans/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@ rclcpp_components_register_node(floorplan_visualizer
EXECUTABLE floorplan_visualizer_node)

#===============================================================================
if(BUILD_TESTING)
option(STYLE_TEST "Run uncrustify to evaluate the code style")
if(BUILD_TESTING AND STYLE_TEST)
find_package(ament_cmake_uncrustify REQUIRED)
find_package(rmf_utils REQUIRED)
find_file(uncrustify_config_file
Expand Down
3 changes: 2 additions & 1 deletion rmf_visualization_navgraphs/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@ rclcpp_components_register_node(navgraph_visualizer
EXECUTABLE navgraph_visualizer_node)

#===============================================================================
if(BUILD_TESTING)
option(STYLE_TEST "Run uncrustify to evaluate the code style")
if(BUILD_TESTING AND STYLE_TEST)
find_package(ament_cmake_uncrustify REQUIRED)
find_package(rmf_utils REQUIRED)
find_file(uncrustify_config_file
Expand Down
3 changes: 2 additions & 1 deletion rmf_visualization_obstacles/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ rclcpp_components_register_node(obstacle_visualizer
EXECUTABLE obstacle_visualizer_node)

#===============================================================================
if(BUILD_TESTING)
option(STYLE_TEST "Run uncrustify to evaluate the code style")
if(BUILD_TESTING AND STYLE_TEST)
find_package(ament_cmake_uncrustify REQUIRED)
find_package(rmf_utils REQUIRED)
find_file(uncrustify_config_file
Expand Down
3 changes: 2 additions & 1 deletion rmf_visualization_rviz2_plugins/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ find_package(rviz_rendering REQUIRED)
find_package(rviz_default_plugins REQUIRED)
find_package(rmf_traffic_ros2 REQUIRED)

if(BUILD_TESTING)
option(STYLE_TEST "Run uncrustify to evaluate the code style")
if(BUILD_TESTING AND STYLE_TEST)
find_package(ament_cmake_uncrustify REQUIRED)
find_package(rmf_utils REQUIRED)
find_file(uncrustify_config_file
Expand Down
3 changes: 2 additions & 1 deletion rmf_visualization_schedule/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ find_package(rmf_visualization_msgs REQUIRED)
find_package(Eigen3 REQUIRED)
find_package(Threads)

if(BUILD_TESTING)
option(STYLE_TEST "Run uncrustify to evaluate the code style")
if(BUILD_TESTING AND STYLE_TEST)
find_package(ament_cmake_uncrustify REQUIRED)
find_package(rmf_utils REQUIRED)
find_file(uncrustify_config_file
Expand Down
Loading