Use default CI matrix#94
Merged
Merged
Conversation
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
mxgrey
previously approved these changes
Jun 16, 2026
Contributor
|
Related to #Open-RMF PMC (Restricted posting) > Removal of uncrustify from "old" core packages? @ 💬, there seem to be uncrustify failures for certain distros. I'll remove uncrustify as a required test, similar to what I did for |
luca-della-vedova
left a comment
luca-della-vedova
left a comment
Member
Author
There was a problem hiding this comment.
There are two different issues here, humble seems to fail because the rmf_visualization_building_systems Python tests are not detected and CI reports NO TESTS RAN, which is an error.
resolute fails on Uncrustify changing behavior, perhaps we can consider removing uncrustify like we did in other repos?
Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai>
Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai>
mxgrey
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to open-rmf/nlohmann_json_schema_validator_vendor#23, the plugins should still build under all supported ROS distros so we remove the manual override to validate that and reduce maintenance burden