Ruby 2.2+ compatibility#10
Conversation
… 2.3s openssl ext
Ruby 2.2+ compatibility
|
Wouldn't this break compatibility with ruby < 2.2? Since in those versions the cipher context is just data and not typed data. |
|
It'll break - I'll PR a backwards compatible change. Thx for flagging. |
Only use the typed data interface for Ruby version >= 2.2.0
|
Merged the PR upstream. Review bump with the full changeset that also is backwards compat as per comments from @jtdowney in Shopify#2 (comment) |
|
I am not sure who has the ability to merge this and bump the version but @Lordnibbler owns the rubygem. |
|
@jtdowney I do not have the ability to merge any longer, you would need someone at OneLogin to do this for you. I am the owner of the gem on Rubygems and could cut a new release, but ideally someone at OneLogin should take ownership and handle this in the future. Let me try and ping some folks: |
Bump to version 1.8.2
|
@Lordnibbler I think at this point it might be time to fork the source and give it to someone IE shopify to maintain. LONG LIVE THE MIT LICENSE |
|
@ryanong sorry I wish I could but I haven’t worked with onelogin since 2015, so I’m no longer an owner :( |
|
I mean as the push owner of the gem, you could change the source of the gem. |
|
And status update here? Or is this dead in the water? |
|
I no longer have write access to this Gem, and although Rubygems thinks I am the owner/author I no longer have access to any machines with credentials to change owners. Someone from Onelogin would have to help. I'm not entirely sure how to tell who can do this. |
|
I am shooting in the dark here, but I saw that @pitbulk pushed to onelogin/ruby-saml recently so perhaps they know how to get this either a) maintained at onelogin or b) transferred so the community can support it. |
|
Hi, I will try to ask at onelogin who can do it. (I pushed ruby-saml with my user, not with onelogin account that is the owner) |
References #8
See Shopify#1 for further context.