This repository was archived by the owner on Jan 18, 2023. It is now read-only.
Only use the typed data interface for Ruby version >= 2.2.0#2
Merged
Conversation
10baf05 to
0d6837e
Compare
|
|
davidsantoso
added a commit
to spreedly/gala
that referenced
this pull request
Apr 6, 2017
See Shopify/aead#2 for more details
davidsantoso
added a commit
to spreedly/gala
that referenced
this pull request
Apr 6, 2017
See Shopify/aead#2 for more details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses concern in onelogin#10 (comment)
Gist of the change:
RUBY_API_VERSION_CODEconstant inruby/version.hI think it's OK to skip
v2_2_0_preview2andv2_2_0_rc1and standardise onv2_2_0as the version that should start using the typed_data interface for this extension.@pallan @csfrancis @jnormore @stonith