Removed deprecated Unicode arguments - #149
Conversation
There was a problem hiding this comment.
@lhapp27
The constructor functions can be eliminated by using @kwdef.
#143 (comment)
But what about the default values, I assume we loose them? Is that a problem? |
|
@lhapp27 Antique.jl/src/HarmonicOscillator.jl Lines 4 to 8 in 0367ba1 |
… alias compatibility test
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
==========================================
- Coverage 87.26% 84.64% -2.63%
==========================================
Files 11 11
Lines 377 306 -71
==========================================
- Hits 329 259 -70
+ Misses 48 47 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
I had to add @kwdef to all modules separately. Not sure why this error did not show up in local tests. maybe it is related to #148 . |
This should resolve issue #143
I had again troubles running the tests locally (see #148), so I do the PR without local tests. It may fail, let's see.