Deprecate Unicode arguments

[ohno]

We will completely deprecate Unicode arguments (e.g., mₑ, a₀).

Antique.jl/src/HydrogenAtom.jl

Lines 17 to 33 in 704556c

	function HydrogenAtom(;
	Z::Integer=1,
	m_e=1.0, mₑ=m_e,
	a_0=1.0, a₀=a_0,
	E_h=1.0, Eₕ=E_h,
	hbar=1.0, ℏ=hbar,
	)
	return HydrogenAtom(Z, mₑ, a₀, Eₕ, ℏ)
	end
	function Base.getproperty(model::HydrogenAtom, sym::Symbol)
	sym === :mₑ && return getfield(model, :m_e)
	sym === :a₀ && return getfield(model, :a_0)
	sym === :Eₕ && return getfield(model, :E_h)
	sym === :ℏ && return getfield(model, :hbar)
	return getfield(model, sym)
	end

Related links: #12, #97, #129 (comment).

[ohno]

The third case will be a cause of a bag.

HydrogenAtom(m_e=1.0)         # mₑ=1.0 good
HydrogenAtom(mₑ=2.0)          # mₑ=2.0 good
HydrogenAtom(m_e=1.0, mₑ=2.0) # mₑ=2.0 bad

So, we should delete this function.

[lhapp27]

There is a problem. After removing those two functions there is only the struct remaining, which does not seem to allow named arguments, see the failed test at #149 . I think we still need the functions, and maybe we simply get rid of the special symbols?

[ohno]

I'm sorry, it seems I said something incorrect in the meeting earlier. The previous code supported named arguments with @kwdef.

julia> @kwdef struct HydrogenAtom
         Z::Integer = 1
         m_e::Real = 1.0
         a_0::Real = 1.0
         E_h::Real = 1.0
         hbar::Real = 1.0
       end
HydrogenAtom

julia> HydrogenAtom(Z=1)
HydrogenAtom(1, 1.0, 1.0, 1.0, 1.0)

@kwdef was deleted in 93092e8. Please see line 18 in src/Antique.jl and line 4 in src HarmonicOscillator.jl.

Antique.jl/src/Antique.jl

Lines 17 to 18 in 0367ba1

	# for Julia 1.1
	import Base:@kwdef

Antique.jl/src/HarmonicOscillator.jl

Lines 4 to 8 in 0367ba1

	@kwdef struct HarmonicOscillator
	k = 1.0
	m = 1.0
	ℏ = 1.0
	end

If we restore this, we should be able to delete the function (outer constructor).