Skip to content

fixes: IllegalCreateQs proper validation of IOSQ with invalid QID #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gersner wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixes: IllegalCreateQs proper validation of IOSQ with invalid QID #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion GrpQueues/illegalCreateQs_r10b.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,14 @@ IllegalCreateQs_r10b::RunCoreTest()
}
{
LOG_NRM("Create IOSQ ID #%d but toxify its QID to 0", IOQ_ID);

// Create a valid IOCQ to be associated with the toxic IOSQ
SharedIOCQPtr iocq = SharedIOCQPtr(new IOCQ(gDutFd));
iocq->Init(IOQ_ID, numEntries, true, 0);
SharedCreateIOCQPtr iocqCmd = SharedCreateIOCQPtr(new CreateIOCQ());
iocqCmd->Init(iocq);
IO::SendAndReapCmd(mGrpName, mTestName, CALC_TIMEOUT_ms(1), asq, acq, iocqCmd, "", true);

SharedIOSQPtr iosq = SharedIOSQPtr(new IOSQ(gDutFd));
iosq->Init(IOQ_ID, numEntries, IOQ_ID, 0);

Expand All @@ -127,6 +135,11 @@ IllegalCreateQs_r10b::RunCoreTest()
mask = 0xFFFF;
value = 0;
SendToxicCmd(asq, acq, iosqCmd, dword, mask, value, CESTAT_INVALID_QID);

// Destroy the IOCQ
SharedDeleteIOCQPtr iocqDeleteCmd = SharedDeleteIOCQPtr(new DeleteIOCQ());
iocqDeleteCmd->Init(iocq);
IO::SendAndReapCmd(mGrpName, mTestName, CALC_TIMEOUT_ms(1), asq, acq, iocqDeleteCmd, "", true);
}
{
LOG_NRM("Create IOSQ ID #%d but wrongly associate to ACQ", IOQ_ID);
Expand All @@ -140,7 +153,7 @@ IllegalCreateQs_r10b::RunCoreTest()
dword = 11;
mask = 0xFFFF0000;
value = 0;
SendToxicCmd(asq, acq, iosqCmd, dword, mask, value, CESTAT_INVALID_QID);
SendToxicCmd(asq, acq, iosqCmd, dword, mask, value, CESTAT_CQ_INVALID);
}
}

Expand Down
2 changes: 2 additions & 0 deletions Utils/queues.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
#include "../Queues/acq.h"
#include "../Cmds/createIOCQ.h"
#include "../Cmds/createIOSQ.h"
#include "../Cmds/deleteIOCQ.h"
#include "../Cmds/deleteIOSQ.h"
#include "../Utils/irq.h"


Expand Down