feat(chart): add stores[].plainHttp for HTTP registries#2582
Open
fseldow wants to merge 2 commits into
Open
Conversation
fseldow
requested review from
akashsinghal,
binbin-li,
jimmyraywv,
luisdlp,
susanshi and
toddysm
as code owners
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds support for configuring non-TLS (plain HTTP) registry access for the Ratify Gatekeeper provider by introducing a plainHttp store setting and wiring it into the rendered executor configuration.
Changes:
- Added
plainHttp(defaultfalse) to thestoresvalues schema. - Updated the executor template to emit
plainHttp: truewhen enabled per store.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| deployments/ratify-gatekeeper-provider/values.yaml | Introduces a plainHttp toggle in store configuration (default off). |
| deployments/ratify-gatekeeper-provider/templates/executor.yaml | Renders plainHttp in generated config when enabled for a store. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2582 +/- ##
=======================================
Coverage 77.62% 77.62%
=======================================
Files 105 105
Lines 4657 4657
=======================================
Hits 3615 3615
Misses 893 893
Partials 149 149 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
fseldow
force-pushed
the
xinhl/chart-plainhttp
branch
2 times, most recently
from
0d591b1 to
a7b1732
Compare
Adds an opt-in plainHttp toggle on each store in the ratify-gatekeeper-provider Helm chart so the rendered Executor CR can talk to registries that do not serve TLS (e.g. local kind clusters and development registries). Defaults to false so existing deployments are unchanged. Signed-off-by: xinhl <xinhl@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
fseldow
force-pushed
the
xinhl/chart-plainhttp
branch
from
a7b1732 to
97b3e13
Compare
Signed-off-by: xinhl <xinhl@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an opt-in
plainHttptoggle on each store in theratify-gatekeeper-providerHelm chart so the renderedExecutorCR can talk to registries that do not serve TLS (e.g. local kind clusters and dev registries).Changes
deployments/ratify-gatekeeper-provider/values.yaml— newstores[].plainHttpfield (defaults tofalse)deployments/ratify-gatekeeper-provider/templates/executor.yaml— renderplainHttp: trueon the store when the value is setBackwards compatibility
Default is
false, so existing deployments render exactly the same Executor as before.Motivation
Needed by the upcoming v2 Executor CRD e2e workflow which uses a local insecure registry. Split out of #2565 so it can land independently.
Testing
helm templateof the chart with and without--set stores[0].plainHttp=truerenders the expected diff.