feat(inlay-hint): implement deterministic definition tracing for pkgs#846
Draft
Malix-Labs wants to merge 1 commit into
Draft
feat(inlay-hint): implement deterministic definition tracing for pkgs#846Malix-Labs wants to merge 1 commit into
Malix-Labs wants to merge 1 commit into
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIXES: #835
This PR implements deterministic definition tracing for the
pkgsscope to resolve issue #835.Agent Information
What I Was Instructed to Do:
with pkgs;#835.Summary of Work:
resolvesToPkgshelper function tonixd/lib/Controller/AST.cpp. It traces expressions back to the Nixpkgs root by:DS_Let) and recursive attribute bindings (DS_Rec).import <nixpkgs>orimportcalls referencing Nixpkgs paths.inputs.nixpkgs.legacyPackages.${system}).havePackageScopeinnixd/lib/Controller/AST.cppto useresolvesToPkgs, cleanly removing the old name-based heuristics.mkVarSelectorinnixd/lib/Controller/AST.cppto return an empty selector (Nixpkgs root) for any traced variable resolving topkgs.dfstraversal innixd/lib/Controller/InlayHints.cppto handleNode::NK_ExprSelect, resolving select paths using the updated idioms selector and preventing duplicate lookups on the base.nix buildandnix flake checkto confirm everything compiles successfully without errors.