Package Version Inlay Hints Does Not Work Without `with pkgs;`

[Malix-Labs]

Describe the bug

Package version inlay hints does not work without with pkgs;

Example

Works

{ pkgs, ... }:
{
  key = with pkgs; [
    hello
  ];
}

Broken

{ pkgs, ... }:
{
  key = [
    pkgs.hello
  ];
}

To Reproduce

1. Works

   { pkgs, ... }:
   {
     key = with pkgs; [
       hello
     ];
   }

2. Broken

   { pkgs, ... }:
   {
     key = [
       pkgs.hello
     ];
   }

Expected behavior

Working package version inlay hints even without with pkgs;

Additional context

Related

• Don't display version of lib #643
• Add Inlay Hints version support for nested packages #713

[Malix-Labs]

Given that :

{ pkgs, ... }:
{
  key = with pkgs; [
    pkgs.hello
  ];
}

Is also broken :

I am starting to think this issue might be in the scope of #713

[inclyc]

These issues/PRs are essentially addressing the heuristic algorithm problems in nixd: I previously only handled a limited set of common cases as "approximations".

Fixing it is straightforward: Option 1: add more cases to these algorithms to quickly resolve the current issues, but more will keep appearing later. Option 2: design a relatively deterministic algorithm with acceptable performance to accurately determine what pkgs really is, so we no longer need to patch up the existing heuristic approach.

Unfortunately, I don't have time to do both at the same time. I'm very grateful to @Malix-Labs for all the valuable feedback on the nixd repository. If you have time to push these things forward (e.g. just fwd issues to codex/claude), maybe we can discuss and review PRs together, which at least could keep things moving forward. What are your thoughts?

[Malix-Labs]

@inclyc I spent tokens on a vibe-slopped #846, if you wanna check