feat(code-action): add quickfix to remove unused let bindings#779
Merged
Conversation
- Detect unused let bindings in VariableLookup and provide a fix - Mark "remove unused binding" as preferred quickfix in CodeAction - Update tests to check for unused binding quickfix in various scenarios - Add new tests for all-unused, basic, multiline, and multiple-bindings cases
8062023 to
00958de
Compare
3 tasks
inclyc
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add code action to remove unused bindings from let expressions.
Example Transformation:
let x = 1; in 2let in 2let x = 1; y = 2; in ylet y = 2; in ylet x = 1; y = 2; in 3let y = 2; in 3(each gets separate action)Changes
libnixf/src/Sema/VariableLookup.cppDK_UnusedDefLetdiagnosticsnixd/lib/Controller/CodeAction.cppisPreferred: truefor unused binding quickfixBehavior
Action offered when:
DK_UnusedDefLetexistsAction NOT offered when:
inheritstatement (intentionally excluded)Handles removal:
= value;Test Plan
-Dwerror=truebasic.md: Remove single unused bindingmultiple-bindings.md: Remove one of multiple bindingsall-unused.md: All bindings unused (each gets separate action)multiline.md: Multiline let expression formattingunquote-let-invalid.md: Interaction with unquote action (updated)unquote-let-keyword.md: Interaction with unquote action (updated)Related