feat(code-action): add quickfix to remove extra with expression#786
Closed
takeokunn wants to merge 1 commit into
Closed
feat(code-action): add quickfix to remove extra with expression#786takeokunn wants to merge 1 commit into
takeokunn wants to merge 1 commit into
Conversation
- Add DK_ExtraWith to preferred code actions in CodeAction.cpp - Add tests for remove extra with on basic and multiline expressions - Ensure action is not offered when with is actually needed
3 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the "remove extra
withexpression" quickfix as a preferred code action.Changes
DK_ExtraWithdiagnostic fixes asisPreferredin CodeAction.cppBehavior
Unused
with→ quickfix offered with isPreferred: truewith→ no removal action offeredTest Plan
Related