Add Inlay Hints version support for nested packages#713
Open
p32blo wants to merge 7 commits into
Open
Conversation
inclyc
reviewed
Aug 31, 2025
inclyc
left a comment
inclyc
left a comment
Member
There was a problem hiding this comment.
Thanks for your contribution! Can you add some regression tests for this new feature?
inclyc
reviewed
Aug 31, 2025
p32blo
force-pushed
the
inlay-hints-expr-select
branch
2 times, most recently
from
085cfa2 to
818ee11
Compare
Author
|
Hey, I've tried to update the PR with some tests. I'm not sure this is exactly what you ment, so let me know If there is any problem :) |
inclyc
approved these changes
Sep 3, 2025
inclyc
reviewed
Sep 8, 2025
p32blo
force-pushed
the
inlay-hints-expr-select
branch
from
818ee11 to
34b5cea
Compare
Co-authored-by: Yingchi Long <longyingchi24s@ict.ac.cn>
p32blo
force-pushed
the
inlay-hints-expr-select
branch
from
34b5cea to
6919c69
Compare
inclyc
requested changes
Sep 12, 2025
| @@ -0,0 +1,51 @@ | |||
| # RUN: nixd --lit-test \ | |||
| # RUN: --nixpkgs-expr="{ nerd-fonts.fira-code.version = \"3.4.0\"; }" \ | |||
| # RUN: < %s | |||
Member
There was a problem hiding this comment.
I just made this hack code to show that nixd may crash in this case.
with pkgs; [ nerd-fonts. ] # user editing the expression
inclyc
reviewed
Sep 12, 2025
| const auto &Sel = static_cast<const ExprSelect &>(*N); | ||
| Params P; | ||
| P.emplace_back(Sel.expr().src(Src)); | ||
| for (const auto &Name : Sel.path()->names()) |
Member
There was a problem hiding this comment.
This might be nullptr, in that case
inclyc
force-pushed
the
main
branch
2 times, most recently
from
ed5029e to
6707401
Compare
2 tasks
Contributor
|
Could you please verify that #835 (comment) is in the scope of this PR too? In which case it could be added to the PR description to close it automatically |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends inlay hints support for packages that have dots ('.') in their name like
nerd-fonts.fira-code.Before
After
Bug Fixes
VLA.query(Var)to check that the name is not a variable defined in the current scopelib#643 by never allowing thenixd::idioms::Libto be an evaluated package name.